Fix smartstep, toggle smart step #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to the V2 architecture
Refactor the target/CDTP model
Fix .scripts command
Finish resolving merge conflicts
Merge location model updates
Fix import casing
digeff
reviewed
Jan 22, 2019
| } | ||
|
|
||
| if ((await this._sourceMapTransformer.allSources(clientPath.canonicalized)).length) { | ||
| if ((await this._sourceMapTransformer.allSources(frame.location.script.runtimeSource.identifier.canonicalized)).length) { |
Owner
There was a problem hiding this comment.
Is this equivalent to script.mappedSources.length?
Owner
|
My original plan was to refactor the code to call that same logic, without going through OnPause |
digeff
reviewed
Jan 28, 2019
| if (paused.reason !== 'other') return false; | ||
|
|
||
| const frame = paused.callFrames[0]; | ||
| const mapping = await this._sourceMapTransformer.mapToAuthored(frame.location.script.url, frame.codeFlow.location.position.lineNumber, frame.codeFlow.location.position.columnNumber); |
Owner
There was a problem hiding this comment.
Is this equivalent to frame.location.mappedToSource().resource.isMappedSource() ?
Fix skipFiles/toggle skip files
digeff
force-pushed
the
v2_latest
branch
4 times, most recently
from
7c6a06b to
f57c9f6
Compare
digeff
force-pushed
the
v2_latest
branch
4 times, most recently
from
376eb91 to
ecf1223
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes smartStep work with one thing missing.
When we toggle smart step, previously we called
onPauseagain to do two things:originDoing this with the way things are now broken up is an interesting problem. I think this isn't critical and we can leave it out for now, but I'm curious whether you have any ideas about how to do that at all?