Personalisering #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I may be missing something here, but have you rewritten the module as almost every thing is marked as new ? If not it might be do to line endings or the change of file permissions. Could you look into this :-) It's very hard to review the code when every line is marked as changed. I will just mention that we currently are waiting on a larger PR from DBC/PH on the alma module and that this PR may need to be rebased after that. So in-depth review is on standby until the DBC PR have been conducted. |
Member
|
@cableman Our repo is now public. |
wiredloose
pushed a commit
to vejlebib-ding2/alma
that referenced
this pull request
Jan 2, 2014
Added alma_availability_items function to get more availability information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.