Skip to content

Conversation

@sarahwalters
Copy link
Collaborator

Hey Zoher, this looks good! Because I can tell that you understand how everything fits together and because you told us the homework didn't feel too hard, I was picky about code style -- comments and changes in the code.

A few overarching things:

  • you're pretty consistently using two patterns to add properties to an object, sometimes one line after the next. It's a little superfluous to define an object e.g. var cats = {whatever: something}; and on the next line do cats[anotherKey] = someValue; -- you could have just done var cats = {whatever: something, anotherKey: someValue};
  • your code is a little wordy -- long lines, some things are repeated which probably didn't need to be, things are cast .toString() which were probably already strings, etc. I'm going to challenge you to be as concise/elegant as possible next time around -- exactly as much code as you need, no more

Remember not to merge these pull requests -- take a look at the feedback, feel free to comment if you'd like to discuss anything, and then close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants