api: implement GET /api/agents/:id to fix remote-mode welcome message #1047
+105
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in remote mode Signed-off-by: 26tanishabanik <26tanishabanik@gmail.com>
rumpl
reviewed
Dec 7, 2025
pkg/server/server.go
Outdated
| id := c.Param("id") | ||
|
|
||
| src, ok := s.sm.sources[id] | ||
| if !ok { |
Member
There was a problem hiding this comment.
Let's remove a 404 if the id isn't found, we do have the /agents so the ID should be known
Author
There was a problem hiding this comment.
I ran the cagent with below command:
> ./bin/cagent api examples/welcome_message.yaml
Listening on [::]:8080
{"time":"2025-12-08T14:42:03.689901+05:30","id":"","remote_ip":"::1","host":"localhost:8080","method":"POST","uri":"/api/sessions","user_agent":"Go-http-client/1.1","status":200,"error":"","latency":841333,"latency_human":"841.333µs","bytes_in":228,"bytes_out":230}
Fetching agent with ID: examples/welcome_message.yaml
Agent found? false
{"time":"2025-12-08T14:42:03.691819+05:30","id":"","remote_ip":"::1","host":"localhost:8080","method":"GET","uri":"/api/agents/examples/welcome_message.yaml","user_agent":"Go-http-client/1.1","status":200,"error":"","latency":439000,"latency_human":"439µs","bytes_in":0,"bytes_out":736}
Fetching agent with ID: examples/welcome_message.yaml
Agent found? false
{"time":"2025-12-08T14:42:03.694068+05:30","id":"","remote_ip":"::1","host":"localhost:8080","method":"GET","uri":"/api/agents/examples/welcome_message.yaml","user_agent":"Go-http-client/1.1","status":200,"error":"","latency":216833,"latency_human":"216.833µs","bytes_in":0,"bytes_out":736}And then sent a request like this:
./bin/cagent run --remote http://localhost:8080 examples/welcome_message.yamlWithout the first !ok block, the welcome message doesn't come, do you want me to just remove the second !ok block? @rumpl
Member
There was a problem hiding this comment.
We would actually need something like this: #1046
Basically it would seem that our urls are not defined as they should
…t instead of a separate agent by id endpoint and adds supporting unit test
Member
|
Let's close it. This has been fixed with #1143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing GET /api/agents/:id, since the remote client already calls GetAgent and needs the exact config. Without it, remote mode can’t read welcome_message, hence the welcome never shows.
Fixes #973