Skip to content

Conversation

@bikegeek
Copy link
Collaborator

@bikegeek bikegeek commented Jul 30, 2025

Pull Request Testing

  • Describe testing already performed for these changes:

    set up on Mac and seneca and generated filled contour with example data

    generates the following plot with custom colormap and dashed lines for contour line:

Screenshot 2025-07-30 at 17 22 19
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    verify that plot can be generated following the README_TCRMW on 'seneca':

    /d1/projects/HAFS_TC-RMW/

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [NA]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe: Perhaps due to Quality Gate coverage falling below threshold

  • Please complete this pull request review by [By August 27].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.2 Development Jul 30, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-6.2 Development Jul 30, 2025
@bikegeek bikegeek added this to the METplotpy-3.2.0 milestone Jul 30, 2025
@bikegeek bikegeek requested a review from KathrynNewman July 30, 2025 23:20
@bikegeek bikegeek linked an issue Aug 5, 2025 that may be closed by this pull request
23 tasks
@bikegeek bikegeek moved this from 🟢 Ready to 🔎 In review in METplus-6.2 Development Aug 5, 2025
@bikegeek bikegeek moved this from 🔎 In review to 🟢 Ready in METplus-6.2 Development Aug 5, 2025
@JohnHalleyGotway JohnHalleyGotway moved this from 🟢 Ready to 🔎 In review in METplus-6.2 Development Aug 21, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-7.0 Development Sep 29, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-7.0 Development Sep 29, 2025
@bikegeek bikegeek moved this from 🟢 Ready to 🔎 In review in METplus-7.0 Development Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Provide support for filled contouring in TC-RMW plot

3 participants