-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fire Dialog: Data storage #7282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+738
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0292795 to
0f21636
Compare
CDRussell
approved these changes
Dec 10, 2025
app/src/main/java/com/duckduckgo/app/fire/store/FireDataStore.kt
Outdated
Show resolved
Hide resolved
d2c0980 to
b4a869f
Compare
This was referenced Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212237599845918?focus=true
Description
This PR adds a new
FireDataStore, which allows to store automatic and manual data-clearing options. There is a newFireClearOptionenum that has 3 options:TABS,DATAandDUCKAI_CHATS.Steps to test this PR
Note
Adds a DataStore-backed FireDataStore to manage manual and automatic clear options (incl. when), a new FireClearOption enum, DI module, and unit tests with legacy settings migration.
FireDataStoreinterface andSharedPreferencesFireDataStoreimplementation backed byDataStore<Preferences>.manualandautomaticclearing: flows, getters, setters, add/remove, and selection checks.getAutomaticallyClearWhenOption*with migration from legacySettingsDataStore(ClearWhatOption,ClearWhenOption).TABS+DATAand fallback to legacy for automatic.@FireDataDataStoreviaFireDataStoreModuleusingpreferencesDataStore(fire_clearing_preferences).FireClearOptionenum:TABS,DATA,DUCKAI_CHATS.Written by Cursor Bugbot for commit b4a869f. This will update automatically on new commits. Configure here.