Skip to content

Conversation

@0nko
Copy link
Member

@0nko 0nko commented Dec 4, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1212237599845918?focus=true

Description

This PR adds a new FireDataStore, which allows to store automatic and manual data-clearing options. There is a new FireClearOption enum that has 3 options: TABS, DATA and DUCKAI_CHATS.

Steps to test this PR

  • Make sure the unit tests pass

Note

Adds a DataStore-backed FireDataStore to manage manual and automatic clear options (incl. when), a new FireClearOption enum, DI module, and unit tests with legacy settings migration.

  • Fire clearing storage:
    • Add FireDataStore interface and SharedPreferencesFireDataStore implementation backed by DataStore<Preferences>.
    • Manage separate option sets for manual and automatic clearing: flows, getters, setters, add/remove, and selection checks.
    • Persist "when to clear" via getAutomaticallyClearWhenOption* with migration from legacy SettingsDataStore (ClearWhatOption, ClearWhenOption).
    • Parse/validate persisted enums; default manual options to TABS + DATA and fallback to legacy for automatic.
  • DI/Module:
    • Provide qualified @FireData DataStore via FireDataStoreModule using preferencesDataStore (fire_clearing_preferences).
  • Models:
    • Introduce FireClearOption enum: TABS, DATA, DUCKAI_CHATS.
  • Tests:
    • Add comprehensive unit tests covering flows, add/remove, independence of manual vs automatic sets, and legacy migration for both "what" and "when".

Written by Cursor Bugbot for commit b4a869f. This will update automatically on new commits. Configure here.

Copy link
Member Author

0nko commented Dec 4, 2025

@0nko 0nko changed the title Add a FireDataStore for new clearing options Fire Dialog: Data storage Dec 4, 2025
@0nko 0nko marked this pull request as ready for review December 4, 2025 21:01
@0nko 0nko force-pushed the feature/ondrej/fire-dialog-data-storage branch from 0292795 to 0f21636 Compare December 5, 2025 16:06
@CDRussell CDRussell self-assigned this Dec 10, 2025
@0nko 0nko force-pushed the feature/ondrej/fire-dialog-data-storage branch from d2c0980 to b4a869f Compare December 11, 2025 08:22
@0nko 0nko mentioned this pull request Dec 11, 2025
1 task
@0nko 0nko merged commit aa3d17b into develop Dec 11, 2025
11 checks passed
@0nko 0nko deleted the feature/ondrej/fire-dialog-data-storage branch December 11, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants