GHA: Simplify CI flow #7301
GHA: Simplify CI flow #7301
Conversation
daxmobile
left a comment
daxmobile
left a comment
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
actionlint
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:31: Double quote to prevent globbing and word splitting [shellcheck]
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:52: Double quote to prevent globbing and word splitting [shellcheck]
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:9:46: Double quote to prevent globbing and word splitting [shellcheck]
🚫 [actionlint] reported by reviewdog 🐶
property "gh_asana_workspace_id" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
🚫 [actionlint] reported by reviewdog 🐶
property "malicious_site_protection_auth_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
| fetch-depth: 0 # required due to setting Spotless ratchetFrom | ||
| submodules: recursive | ||
| token: ${{ secrets.GT_DAXMOBILE }} | ||
| ref: ${{ github.event.inputs.ref }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "ref" is not defined in object type {} [expression]
| required: true | ||
|
|
||
| env: | ||
| ASANA_PAT: ${{ secrets.ASANA_ACCESS_TOKEN }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "asana_access_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; github_token: string; mm_auth_token: string; mm_team_id: string} [expression]
| outputs: | ||
| asana-task-url: | ||
| description: "The URL of the created Asana task" | ||
| value: ${{ jobs.create_release_task.outputs.asana_task_url }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "asana_task_url" is not defined in object type {} [expression]
| name: 'Step 1: Notify Mattermost of Release start' | ||
| uses: ./.github/workflows/notify_mattermost.yml | ||
| with: | ||
| mattermost-message: ${{env.emoji_start}} Starting release process for version ${{ github.event.inputs.app-version }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
context "env" is not allowed here. available contexts are "github", "inputs", "matrix", "needs", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details [expression]
|
|
||
| create_task: | ||
| name: 'Step 2: Create Asana Task' | ||
| uses: ./.github/workflows/release_create_task.yml |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
secret "ASANA_ACCESS_TOKEN" is required by "./.github/workflows/release_create_task.yml" reusable workflow [workflow-call]
| asana-task-url: ${{ needs.create_task.outputs.asana-task-url }} | ||
| secrets: inherit | ||
|
|
||
| upload_internal: |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
job "upload_internal" needs job "run_tests" which does not exist in this workflow [job-needs]
| needs: run_tests | ||
| uses: ./.github/workflows/release_upload_internal.yml | ||
| with: | ||
| app-version: ${{ github.event.inputs.app-version }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
input "app-version" is not defined in "./.github/workflows/release_upload_internal.yml" reusable workflow. no input is defined [workflow-call]
| uses: ./.github/workflows/release_upload_internal.yml | ||
| with: | ||
| app-version: ${{ github.event.inputs.app-version }} | ||
| asana-task-url: ${{ needs.create_task.outputs.asana-task-url }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
input "asana-task-url" is not defined in "./.github/workflows/release_upload_internal.yml" reusable workflow. no input is defined [workflow-call]
| uses: ./.github/workflows/release_upload_internal.yml | ||
| with: | ||
| app-version: ${{ github.event.inputs.app-version }} | ||
| asana-task-url: ${{ needs.create_task.outputs.asana-task-url }} |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "create_task" is not defined in object type {} [expression]
| uses: ./.github/workflows/notify_mattermost.yml | ||
| needs: upload_play_store | ||
| with: | ||
| mattermost-message: ${{env.emoji_end}} Release ${{ github.event.inputs.app-version }} completed successfully and is now in review. |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
context "env" is not allowed here. available contexts are "github", "inputs", "matrix", "needs", "strategy", "vars". see https://docs.github.com/en/actions/learn-github-actions/contexts#context-availability for more details [expression]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:9:24: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:12:38: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:16:22: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:3:30: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
input "github_token" is not defined in action "Check for code changes after a specific tag" defined at "./.github/actions/check-for-changes-since-tag". available inputs are "tag" [action]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:73: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "netp_debug_server_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:27: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:2:31: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:1:52: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:9:46: Double quote to prevent globbing and word splitting [shellcheck]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "gh_asana_workspace_id" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; malicious_site_protection_auth_token: string; mm_auth_token: string; mm_team_id: string; upload_firebase_credentials: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_properties" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "upload_release_key" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
property "malicious_site_protection_auth_token" is not defined in object type {actions_runner_debug: string; actions_step_debug: string; asana_access_token: string; github_token: string; gt_daxmobile: string; mm_auth_token: string; mm_team_id: string; upload_play_credentials: string} [expression]
| test-tag: | ||
| description: 'Maestro Tests tag to include' | ||
| required: true | ||
| default: 'releaseTest' |
There was a problem hiding this comment.
🚫 [actionlint] reported by reviewdog 🐶
input "test-tag" of workflow_call event has the default value "releaseTest", but it is also required. if an input is marked as required, its default value will never be used [events]
There was a problem hiding this comment.
📝 [actionlint] reported by reviewdog 🐶
shellcheck reported issue in this script: SC2086:info:45:45: Double quote to prevent globbing and word splitting [shellcheck]
Android/.github/workflows/release_tests.yml
Line 118 in 51fd7c3
2 participants
Task/Issue URL:
Description
Steps to test this PR
Feature 1
UI changes