Skip to content

Conversation

@joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Dec 10, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211755763011422?focus=true

Description

  • This is no longer needed since Duck.ai is currently tied to the BrowserActivity using DuckChatWebViewFragment

Steps to test this PR

  • Open Duck.ai
  • Verify that it is launched correctly

Note

Deletes the standalone DuckChatWebViewActivity and shifts opening/closing Duck.ai to BrowserNav with updated session handling; cleans up manifest and tests.

  • DuckChat flow:
    • Remove DuckChatWebViewActivity and DuckChatWebViewActivityViewModel (and related tests).
    • In RealDuckChat, drop keepSession and standalone activity path; always use BrowserNav.openDuckChat/closeDuckChat.
    • Adjust session logic: hasSessionActive now based on hasActiveSession() unless forceNewSession.
    • Remove DuckChatWebViewActivityWithParams usage and startDuckChatActivity helper.
  • Manifest:
    • Delete com.duckduckgo.duckchat.impl.ui.DuckChatWebViewActivity entry.
  • Tests:
    • Update RealDuckChatTest to assert BrowserNav intents and active-session behavior; remove obsolete WebView activity tests.

Written by Cursor Bugbot for commit 6957e7a. This will update automatically on new commits. Configure here.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@malmstein malmstein self-assigned this Dec 10, 2025
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up 🔥

Some tests are failing but I’m approving so it’s not blocked

@joshliebe joshliebe force-pushed the feature/josh/delete-duck-chat-activity branch from 9f53e6a to 6957e7a Compare December 10, 2025 11:12
@joshliebe joshliebe merged commit a76e73c into develop Dec 10, 2025
11 checks passed
@joshliebe joshliebe deleted the feature/josh/delete-duck-chat-activity branch December 10, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants