Add unit tests for pseudo_kl_divergence_loss #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinchern
requested changes
Dec 22, 2025
Collaborator
kevinchern
left a comment
kevinchern
left a comment
There was a problem hiding this comment.
Hi Ahmed @abdela47. Thank you for the pull request.
The tests are well-reasoned, modular, and nicely documented.
I did a quick first pass and added some minor requests.
Separately, you may find this contribution guide helpful for our conventions and best-practices.
tests/test_pseudo_kl_divergence.py
Outdated
Comment on lines
88
to
91
| logits = torch.zeros(batch, n_spins) | ||
|
|
||
| # spins: (batch_size, n_samples, n_spins) | ||
| spins = torch.ones(batch, n_samples, n_spins) |
Collaborator
There was a problem hiding this comment.
Could you explain your rationale for using zero-valued logits and spins in this test versus nonzero values in the 2d test?
Author
There was a problem hiding this comment.
Zero logits are used in the 3D shape test to keep the entropy term simple and stable (p = 0.5), allowing the test to focus purely on documented shape support; nonzero values are covered in the 2D numerical correctness test.
Co-authored-by: Kevin Chern <32395608+kevinchern@users.noreply.github.com>
…ins_data.shape for clarity and consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds deterministic unit tests for pseudo_kl_divergence_loss.
The tests cover both documented spin shapes and verify gradient behavior.
They isolate the statistical structure of the loss using deterministic dummy Boltzmann
machines and do not rely on samplers or quantum hardware.
Closes #56.