Elastic net paths did not uncompress the glmnet indices #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I'm new to github, so I hope I follow the correct channel. Attached a patch that solves a bug in the ElasticNet.py file. In particular, the glmnets returns compressed indices, yet these were not used. Although that doesn't matter when just plotting graphs, it does matter if we try to use the returned models as a predictor. Therefore it is necessary to decompress the coefficients before returning them.
Secondly, the ElasticNet predictor object itself was also blissfully unaware of the indices.
This patch solves these two problems
With kind regards,
Werner,-