add trigger gc api #379
add trigger gc api #379
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4 #379 +/- ##
=====================================
Coverage ? 57.18%
=====================================
Files ? 36
Lines ? 4809
Branches ? 598
=====================================
Hits ? 2750
Misses ? 1773
Partials ? 286 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| pg_id, (priority == task_priority::emergent) ? "emergent" : "normal"); | ||
| } | ||
|
|
||
| // 3.5 Wait for all GC tasks in this PG to complete |
There was a problem hiding this comment.
It may take a long time, right? Just return the job id and let user query the job status?
There was a problem hiding this comment.
yes, if too many chunk need to be gc, it probably take a while, so just return a job id, with which the user can query the job status.
| return; | ||
| } | ||
| // Create new job and set as current (replacing any completed job) | ||
| current_gc_job_ = job_info; |
There was a problem hiding this comment.
If we want to specify the chunk_id, then we can only clean chunks one by one, can we add some concurrency?
| private: | ||
| enum class GCJobStatus { PENDING, RUNNING, COMPLETED, FAILED }; | ||
|
|
||
| struct GCJobInfo { |
There was a problem hiding this comment.
From user's perspective, suggest adding pg_id as well.
JacksonYao287
force-pushed
the
trigger-gc-manually
branch
2 times, most recently
from
e08ac14 to
ec6d1c7
Compare
JacksonYao287
force-pushed
the
trigger-gc-manually
branch
from
ec6d1c7 to
6d9a9d0
Compare
3 participants
1 trigger gc for all chunks
curl -k https://127.0.0.1:10443/api/v1/trigger_gc
2 trigger gc for a specific chunk
curl -k https://localhost:10443/api/v1/trigger_gc?chunk_id=123
3 query the status of a gc job. ATM, we only support one pending gc job
curl https://localhost:10443/api/v1/gc_job_status?job_id=trigger-gc-task-0
all the above apis have been tested manually, UT will be added later in a separate PR