Skip to content

Conversation

@Besroy
Copy link
Contributor

@Besroy Besroy commented Dec 15, 2025

This change use NuRaft's native binary serialization to persist srv_state instead of manual JSON field mapping. This ensures all state fields including receiving_snapshot_ are saved, preventing state inconsistency and unexpected raft behavior.

related issue: #835

@Besroy Besroy requested review from xiaoxichen and yuwmao December 15, 2025 09:20
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 7.14286% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.54%. Comparing base (1a0cef8) to head (045681b).
⚠️ Report is 299 commits behind head on master.

Files with missing lines Patch % Lines
src/lib/replication/repl_dev/raft_repl_dev.cpp 7.14% 1 Missing and 12 partials ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #841      +/-   ##
==========================================
- Coverage   56.51%   49.54%   -6.97%     
==========================================
  Files         108      110       +2     
  Lines       10300    11329    +1029     
  Branches     1402     5345    +3943     
==========================================
- Hits         5821     5613     -208     
+ Misses       3894     2080    -1814     
- Partials      585     3636    +3051     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This change use NuRaft's native binary serialization to persist srv_state instead of manual JSON field mapping.
This ensures all state fields including receiving_snapshot_ are saved, preventing state inconsistency and unexpected raft behavior.
@Besroy Besroy force-pushed the fix_raft_state_trans branch from 2b98201 to 045681b Compare December 16, 2025 01:51
@Besroy Besroy requested a review from yamingk December 16, 2025 01:51
Copy link
Contributor

@yuwmao yuwmao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Besroy Besroy merged commit a90ae8a into eBay:master Dec 21, 2025
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants