Skip to content

Conversation

@rozyczko
Copy link
Member

Enabled import of orso models and conversion to the internal sample

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request does not contain a valid label. Please add one of the following labels: ['chore', 'fix', 'bugfix', 'bug', 'enhancement', 'feature', 'dependencies', 'documentation']

@rozyczko rozyczko added [scope] enhancement Adds/improves features (major.MINOR.patch) [priority] highest Urgent. Needs attention ASAP enhancement labels Nov 24, 2025
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

❌ Patch coverage is 81.13208% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.83%. Comparing base (072f43b) to head (bda1b87).
⚠️ Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
src/easyreflectometry/project.py 8.33% 11 Missing ⚠️
src/easyreflectometry/orso_utils.py 90.78% 5 Missing and 2 partials ⚠️
src/easyreflectometry/model/model.py 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #286      +/-   ##
===========================================
- Coverage    89.61%   88.83%   -0.79%     
===========================================
  Files           44       45       +1     
  Lines         2349     2471     +122     
  Branches       271      288      +17     
===========================================
+ Hits          2105     2195      +90     
- Misses         195      220      +25     
- Partials        49       56       +7     
Flag Coverage Δ
unittests 88.78% <81.13%> (-0.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/easyreflectometry/calculators/calculator_base.py 95.12% <ø> (ø)
src/easyreflectometry/data/data_store.py 91.91% <100.00%> (ø)
src/easyreflectometry/data/measurement.py 89.85% <100.00%> (-2.01%) ⬇️
src/easyreflectometry/utils.py 97.67% <100.00%> (+0.05%) ⬆️
src/easyreflectometry/model/model.py 94.64% <33.33%> (-1.69%) ⬇️
src/easyreflectometry/orso_utils.py 90.78% <90.78%> (ø)
src/easyreflectometry/project.py 78.44% <8.33%> (-2.26%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko rozyczko merged commit f8b1beb into develop Nov 24, 2025
21 of 23 checks passed
@rozyczko rozyczko deleted the orso_models branch November 24, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement [priority] highest Urgent. Needs attention ASAP [scope] enhancement Adds/improves features (major.MINOR.patch)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants