-
Notifications
You must be signed in to change notification settings - Fork 204
Make a context project optional for EclipseRunMojo #5208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Make a context project optional for EclipseRunMojo #5208
Conversation
Test Results1 008 files 1 008 suites 4h 50m 48s ⏱️ For more details on these failures, see this check. Results for commit b20967d. ♻️ This comment has been updated with latest results. |
tycho-eclipse-plugin/src/main/java/org/eclipse/tycho/eclipserun/EclipseRunMojo.java
Outdated
Show resolved
Hide resolved
| } | ||
| cli.setJvmExecutable(executable); | ||
| cli.setWorkingDirectory(project.getBasedir()); | ||
| cli.setWorkingDirectory(project != null ? project.getBasedir() : new File("").getAbsoluteFile()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly maven always create an empty project for you when you execute it from within a directory without a pom.
Beside that a temp directory might be better to use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly maven always create an empty project for you when you execute it from within a directory without a pom.
I don't know that, but I assume the empty project, will then have the current working directory as directory? So basically the same result.
Beside that a temp directory might be better to use?
The idea was that the current working directory where the direct CLI invocation is launched is probably also interesting was working directory of the eclipse run (just 'forwarding' the shell's workding directory to the Eclipse run).
6d7bd78 to
d3fb852
Compare
d3fb852 to
b20967d
Compare
|
I did now make some experiments and there is indeed an empty project injected if no pom is available, but its |
|
What cam into my mind is to define an additional parameter (e.g. |
This might be useful if one wants to run Eclipse from Maven without a context project.