-
Notifications
You must be signed in to change notification settings - Fork 204
Migrate Plexus @Component annotations to JSR330 in 9 modules (excluding tycho-core, demo, tycho-its, p2-maven-plugin, tycho-packaging-plugin, tycho-versions-plugin) #5509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@copilot we exclude p2-maven-plugin (41 files), tycho-packaging-plugin (10 files) and tycho-versions-plugin (12 files) for now to keep the workload managable here! |
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…ipse, p2-publisher, repository, sbom) Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…e migration Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…lugin from migration Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Reverted the changes for p2-maven-plugin (41 files), tycho-packaging-plugin (10 files), and tycho-versions-plugin (12 files) in commit ab9131d. The PR now migrates only 20 files across 9 modules. |
laeubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me
This PR migrates
org.codehaus.plexus.component.annotations.Componentannotated classes to JSR330 annotations (javax.inject.*), following the deprecation of Plexus annotations in favor of JSR330 as documented in the Plexus to JSR330 migration guide.Scope
This migration covers 20 production Java files across 9 modules, excluding
tycho-core,demo,tycho-its,p2-maven-plugin,tycho-packaging-plugin, andtycho-versions-pluginwhich will be handled separately:Changes
Annotation Replacements
@component → @nAmed + @singleton
@requirement → @Inject
@requirement(hint="x") → @Inject + @nAmed("x")
Per-lookup components (omit
@Singletonfor non-singleton lifecycle)Build Configuration
Added
sisu-maven-pluginto 7 affectedpom.xmlfiles to generate the requiredMETA-INF/sisu/javax.inject.Namedindex files for component discovery.Testing
mvn clean install -T1C -DskipTestsNotes
@SessionScopedannotations preserved where presentp2-maven-plugin,tycho-packaging-plugin, andtycho-versions-pluginexcluded from this PR to keep the workload manageable and will be handled separatelytycho-core,demo,tycho-its, and the excluded modules require separate handlingRelates to #1494
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.