Remove 10 obsolete disabled tests, document 7 legitimately ignored tests #5633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewed all 17 disabled tests in the codebase. Deleted 10 that are obsolete or broken by design, kept 7 that have valid reasons to remain disabled.
Deleted Tests (10)
Obsolete features:
DeployableFeatureTest- feature no longer supportedIssue697Test- no tracking, appears obsoleteTargetPlatformArtifactJUnitTest- outdated examplesBroken by design:
RemoteAgentDisableP2MirrorsTest.testDisableP2Mirrors- test implementation doesn't use the parameter it's supposed to testExpect unimplemented validations:
FeatureRootAdvicePermissionsTest.testPermissionsChmodInvalidValueFeatureRootAdviceTest.testParseBuildPropertiesInvalidConfigs2OSGiMetadataGenerationTest.testNonOSGiArtifact_missingArtifactErrorLong-standing bugs without fixes:
MavenFeatureTest.testLocationContentFeatureGeneration- FIXME: wrong bundle includedMavenFeatureTest.testPomArtifactFeatureGeneration- FIXME: missing pom unitTargetPlatformFactoryTest.testMavenArtifactsInTargetDefinitionResolveToMavenPath- test setup limitationAlso removed associated test projects:
TYCHO321deployableFeature,issue697,target.artifact.junit.Kept Ignored (7)
All have documented reasons:
OSGiMetadataGenerationTest.testSourceWithSignature- external repo unavailable (GitLab #5987)VerifierServiceImplTest.testFileRepositoryWithTamperedArtifact- Java 17+ disabled signature algorithmsResolverTests.testResolveRebundledMavenDependencies- tracked in Delay wrapping of bundles to the latest possible time #2053ConsumerPomTest.testReplaceP2- Maven Central compatibilityTargetPlatformLocationsTest.testMavenLocationRepositories- flaky on buildserverJava18ResolutionTest- requires Java 18RequireJREPackagesImportTest- pending bug 514471Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
archive.eclipse.org/usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dlibrary.jansi.path=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/tycho/tycho org.codehaus.plexus.classworlds.launcher.Launcher -Declipse.p2.mirrors=false -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dtycho-version=6.0.0-SNAPSHOT -Djava.io.tmpdir=/home/REDACTED/work/tycho/tycho/tycho-its/target/tmp -X -s /home/REDACTED/work/tycho/tycho/tycho-its/settings.xml -e --batch-mode -Dmaven.repo.local=/home/REDACTED/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean compile(dns block)/usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dlibrary.jansi.path=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/tycho/tycho org.codehaus.plexus.classworlds.launcher.Launcher -Declipse.p2.mirrors=false -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dtycho-version=6.0.0-SNAPSHOT -Djava.io.tmpdir=/home/REDACTED/work/tycho/tycho/tycho-its/target/tmp -Dtarget-platform=REDACTED -Dtycho.localArtifacts=ignore -X -s /home/REDACTED/work/tycho/tycho/tycho-its/settings.xml -e --batch-mode -Dmaven.repo.local=/home/REDACTED/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean compile(dns block)repo.eclipse.org/usr/lib/jvm/temurin-21-jdk-amd64/bin/java -jar /home/REDACTED/work/tycho/tycho/tycho-core/target/surefire/surefirebooter-20251120060602455_3.jar /home/REDACTED/work/tycho/tycho/tycho-core/target/surefire 2025-11-20T06-06-02_385-jvmRun1 surefire-20251120060602455_1tmp surefire_0-20251120060602455_2tmp(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.