Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 20, 2025

Reviewed all 17 disabled tests in the codebase. Deleted 10 that are obsolete or broken by design, kept 7 that have valid reasons to remain disabled.

Deleted Tests (10)

Obsolete features:

  • DeployableFeatureTest - feature no longer supported
  • Issue697Test - no tracking, appears obsolete
  • TargetPlatformArtifactJUnitTest - outdated examples

Broken by design:

  • RemoteAgentDisableP2MirrorsTest.testDisableP2Mirrors - test implementation doesn't use the parameter it's supposed to test

Expect unimplemented validations:

  • FeatureRootAdvicePermissionsTest.testPermissionsChmodInvalidValue
  • FeatureRootAdviceTest.testParseBuildPropertiesInvalidConfigs2
  • OSGiMetadataGenerationTest.testNonOSGiArtifact_missingArtifactError

Long-standing bugs without fixes:

  • MavenFeatureTest.testLocationContentFeatureGeneration - FIXME: wrong bundle included
  • MavenFeatureTest.testPomArtifactFeatureGeneration - FIXME: missing pom unit
  • TargetPlatformFactoryTest.testMavenArtifactsInTargetDefinitionResolveToMavenPath - test setup limitation

Also removed associated test projects: TYCHO321deployableFeature, issue697, target.artifact.junit.

Kept Ignored (7)

All have documented reasons:

  • OSGiMetadataGenerationTest.testSourceWithSignature - external repo unavailable (GitLab #5987)
  • VerifierServiceImplTest.testFileRepositoryWithTamperedArtifact - Java 17+ disabled signature algorithms
  • ResolverTests.testResolveRebundledMavenDependencies - tracked in Delay wrapping of bundles to the latest possible time #2053
  • ConsumerPomTest.testReplaceP2 - Maven Central compatibility
  • TargetPlatformLocationsTest.testMavenLocationRepositories - flaky on buildserver
  • Java18ResolutionTest - requires Java 18
  • RequireJREPackagesImportTest - pending bug 514471

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • archive.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dlibrary.jansi.path=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/tycho/tycho org.codehaus.plexus.classworlds.launcher.Launcher -Declipse.p2.mirrors=false -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dtycho-version=6.0.0-SNAPSHOT -Djava.io.tmpdir=/home/REDACTED/work/tycho/tycho/tycho-its/target/tmp -X -s /home/REDACTED/work/tycho/tycho/tycho-its/settings.xml -e --batch-mode -Dmaven.repo.local=/home/REDACTED/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean compile (dns block)
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/bin/m2.conf -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dlibrary.jansi.path=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/tycho/tycho org.codehaus.plexus.classworlds.launcher.Launcher -Declipse.p2.mirrors=false -Dmaven.home=/home/REDACTED/work/tycho/tycho/tycho-its/target/apache-maven-3.9.11 -Dtycho-version=6.0.0-SNAPSHOT -Djava.io.tmpdir=/home/REDACTED/work/tycho/tycho/tycho-its/target/tmp -Dtarget-platform=REDACTED -Dtycho.localArtifacts=ignore -X -s /home/REDACTED/work/tycho/tycho/tycho-its/settings.xml -e --batch-mode -Dmaven.repo.local=/home/REDACTED/.m2/repository org.apache.maven.plugins:maven-clean-plugin:clean compile (dns block)
  • repo.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-21-jdk-amd64/bin/java -jar /home/REDACTED/work/tycho/tycho/tycho-core/target/surefire/surefirebooter-20251120060602455_3.jar /home/REDACTED/work/tycho/tycho/tycho-core/target/surefire 2025-11-20T06-06-02_385-jvmRun1 surefire-20251120060602455_1tmp surefire_0-20251120060602455_2tmp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

Try enabling 20 disabled test

We currently have some disbaled test we should try to enable them again (or decide to delte them if it does not work out well).


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits November 20, 2025 06:02
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable 20 disabled tests and assess their stability Remove 10 obsolete disabled tests, document 7 legitimately ignored tests Nov 20, 2025
Copilot AI requested a review from laeubi November 20, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants