Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 27, 2025

org.apache.maven.repository.RepositorySystem is deprecated and slated for removal in Maven 4.x. This PR migrates all usages to the modern Aether Resolver API (org.eclipse.aether.RepositorySystem), following the pattern established in the maven-compiler-plugin migration.

Migration Pattern

Before:

Artifact artifact = repositorySystem.createArtifact(groupId, artifactId, version, null, packaging);
ArtifactResolutionRequest request = new ArtifactResolutionRequest();
request.setArtifact(artifact);
request.setLocalRepository(session.getLocalRepository());
request.setRemoteRepositories(project.getRemoteArtifactRepositories());
ArtifactResolutionResult result = repositorySystem.resolve(request);

After:

org.eclipse.aether.artifact.Artifact aetherArtifact = new DefaultArtifact(groupId, artifactId, null, extension, version);
ArtifactRequest request = new ArtifactRequest(aetherArtifact, project.getRemoteProjectRepositories(), null);
ArtifactResult result = repositorySystem.resolveArtifact(session.getRepositorySession(), request);

Changes

  • MavenDependenciesResolverConfigurer — Migrated to CollectRequest/DependencyRequest/ArtifactRequest APIs
  • MavenDependencyInjector — Replaced repositorySystem.createArtifactRepository() with direct MavenArtifactRepository instantiation; removed RepositorySystem and Settings parameters
  • P2DependencyResolver — Removed unused RepositorySystem field
  • DefaultStandaloneDirectorRuntimeFactory — Removed unused RepositorySystem field
  • AbstractEclipseTestMojo — Migrated framework extension resolution to Aether API
  • TychoIntegrationTestMojo — Migrated dependency resolution with scope filtering via DependencyFilterUtils
  • DocletArtifactsResolver — Migrated to Aether API
  • MavenDependenciesResolverTest — Updated test setup to use LegacyLocalRepositoryManager.overlay() for proper session configuration
  • P2ArtifactMappingToMavenRepoTest — Replaced RepositorySystem.DEFAULT_REMOTE_REPO_URL constant with literal to remove deprecated import

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • testng.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.23.3/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/tycho/.codeql-scratch/dbs/java/working/files-to-index10798835212826357474.list --sourceArchiveDir=/home/REDACTED/work/tycho/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/tycho/.codeql-scratch/dbs/java/trap/java (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Replace RepositorySystem usages with Aether Resolver</issue_title>
<issue_description>org.apache.maven.repository.RepositorySystem shoudl/could be replaced with Aether Resolver like shown here

https://github.com/apache/maven-compiler-plugin/pull/151/files

For example in the MavenURLHandler.</issue_description>

<agent_instructions>Check where we already use the old org.apache.maven.repository.RepositorySystem and suggest upgrade to using the new Aether API. As we have done this already on some places there should even be examples for such migration in the source code of this repository.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@laeubi Probably related see
Error: [ERROR] Internal error: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories.11532822172687905050.tmp -> C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories.11532822172687905050.tmp -> C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories
    at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:108)
    at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
    at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
    at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
    at jdk.internal.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:77)
    at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke (Method.java:568)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:282)
    at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:225)
    at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:406)
    at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:347)
Caused by: java.io.UncheckedIOException: java.nio.file.AccessDeniedException: C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories.11532822172687905050.tmp -> C:\Users\runneradmin\.m2\repository\commons-fileupload\commons-fileupload\1.5\_remote.repositories
    at org.eclipse.aether.internal.impl.DefaultTrackingFileManager.update (DefaultTrackingFileManager.java:121)
    at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addRepo (EnhancedLocalRepositoryManager.java:274)
    at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.addArtifact (EnhancedLocalRepositoryManager.java:252)
    at org.eclipse.aether.internal.impl.EnhancedLocalRepositoryManager.add (EnhancedLocalRepositoryManager.java:225)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.evaluateDownloads (DefaultArtifactResolver.java:680)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads (DefaultArtifactResolver.java:592)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:478)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts (DefaultArtifactResolver.java:278)
    at org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact (DefaultArtifactResolver.java:255)
    at org.eclipse.aether.internal.impl.DefaultRepositorySystem.resolveArtifact (DefaultRepositorySystem.java:296)
    at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:197)
    at org.apache.maven.artifact.resolver.DefaultArtifactResolver.resolve (DefaultArtifactResolver.java:413)
    at org.apache.maven.repository.legacy.LegacyRepositorySystem.resolve (LegacyRepositorySystem.java:332)
    at org.eclipse.tycho.osgi.configuration.MavenDependenciesResolverConfigurer.resolve (MavenDependenciesResolverConfigurer.java:104)
    at org.eclipse.tycho.core.shared.MavenDependenciesResolver.resolve (MavenDependenciesResolver.java:60)
    at org.eclipse.tycho.core.resolver.MavenTargetDefinitionContent.<init> (MavenTargetDefinitionContent.java:262)
    at org.eclipse.tycho.p2resolver.TargetDefinitionResolver.resolveContentWithExceptions (TargetDefinitionResolver.java:179)
    at org.eclipse.tycho.p2resolver.TargetDefinitionResolver.resolveContent (TargetDefinitionResolver.java:110)
    at org.eclipse.tycho.p2...

</details>

- Fixes eclipse-tycho/tycho#1422

<!-- START COPILOT CODING AGENT TIPS -->
---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

Copilot AI and others added 3 commits November 27, 2025 04:18
Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…lver API

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
…r test

Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot AI changed the title [WIP] Replace RepositorySystem usages with Aether Resolver Replace RepositorySystem usages with Aether Resolver Nov 27, 2025
Copilot AI requested a review from laeubi November 27, 2025 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants