Skip to content

Better error message for status response parsing #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gekctek merged 2 commits into from
Feb 4, 2025
Merged

Better error message for status response parsing #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd7a096
Better error message for status response parsing
Gekctek Feb 4, 2025
be08d58
Making ic_api_version optional
Gekctek Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Agent/API.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions src/Agent/Responses/StatusResponse.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ public class StatusResponse
/// The implementation may also return unversioned to indicate that it does not
/// comply to a particular version, e.g. in between releases.
/// </summary>
public string ICApiVersion { get; }
public string? ICApiVersion { get; }

/// <summary>
/// Optional. Identifies the implementation of the Internet Computer Protocol,
Expand Down Expand Up @@ -44,7 +44,7 @@ public class StatusResponse
/// </summary>
public byte[]? DevelopmentRootKey { get; }

/// <param name="icApiVersion">Identifies the interface version supported, i.e. the version of the present
/// <param name="icApiVersion">Optional. Identifies the interface version supported, i.e. the version of the present
/// document that the internet computer aims to support, e.g. `0.8.1`.
/// The implementation may also return unversioned to indicate that it does not
/// comply to a particular version, e.g. in between releases.</param>
Expand All @@ -61,7 +61,7 @@ public class StatusResponse
/// Internet Computer, agents must have an independent trustworthy source for this data,
/// and must not be tempted to fetch it from this insecure location</param>
public StatusResponse(
string icApiVersion,
string? icApiVersion,
string? implementationSource,
string? implementationVersion,
string? implementationRevision,
Expand Down Expand Up @@ -119,11 +119,6 @@ internal static StatusResponse ReadCbor(CborReader reader)

reader.ReadEndMap();

if (icApiVersion == null)
{
throw new CborContentException("Missing field: " + Properties.IC_API_VERSION);
}

return new StatusResponse(icApiVersion, implementationSource, implementationVersion, implementationRevision, developmentRootKey);
}

Expand Down