-
Notifications
You must be signed in to change notification settings - Fork 3
fix: added logs and record exception for datadog monitoring #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances error logging and monitoring for the LMS user retirement endpoint to diagnose and resolve 133+ failed retirements that lack diagnostic information. The changes add detailed error messages, user identification, and DataDog integration through record_exception() calls.
Key Changes:
- Added structured error logging with user context for all exception types in the retirement flow
- Integrated
record_exception()for DataDog monitoring on all exception paths - Enhanced diagnostic information to track user IDs and error messages
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description:
133+ user retirements are stuck in failed state with no diagnostic information preventing us from fixing them. This change adds detailed logging to identify root causes of retirement failures so we can systematically resolve the existing backlog and prevent future issues.
Solution:
Enhanced exception handling in LMS retirement endpoint with detailed error logging and DataDog integration.
record_exception()calls for monitoringPrivate JIRA Link:
BOMS-290