build: updated ubuntu version to latest #75
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Ubuntu runner versions across GitHub Actions workflows, replacing pinned versions (ubuntu-24.04 and ubuntu-22.04) with the floating tag ubuntu-latest.
Key changes:
- All workflow files now use
ubuntu-latestinstead of specific Ubuntu versions - Changes affect 7 workflow files covering unit tests, static analysis, quality checks, and migrations
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/unit-tests.yml |
Updated matrix os-version and include entries from ubuntu-24.04/22.04 to ubuntu-latest across test matrix and auxiliary jobs |
.github/workflows/static-assets-check.yml |
Changed matrix os from ubuntu-24.04 to ubuntu-latest |
.github/workflows/quality-checks.yml |
Changed matrix os from ubuntu-24.04 to ubuntu-latest |
.github/workflows/pylint-checks.yml |
Updated runs-on from ubuntu-24.04 to ubuntu-latest for both main and success jobs |
.github/workflows/migrations-check.yml |
Changed matrix os and success job runs-on from ubuntu-24.04 to ubuntu-latest |
.github/workflows/ci-static-analysis.yml |
Updated matrix os from ubuntu-24.04 to ubuntu-latest |
.github/workflows/check-consistent-dependencies.yml |
Changed runs-on from ubuntu-24.04 to ubuntu-latest |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - "7.0" | ||
| os-version: | ||
| - ubuntu-24.04 | ||
| - ubuntu-latest |
There was a problem hiding this comment.
The PR description states "Updating the latest version of ubuntu" which suggests updating to a specific latest version (e.g., ubuntu-24.04). However, the code changes replace pinned versions (ubuntu-24.04 and ubuntu-22.04) with the floating tag ubuntu-latest. This is a significant difference - using ubuntu-latest means the Ubuntu version will automatically change when GitHub updates their runner images, which could introduce unexpected breaking changes. If the intention is to pin to the latest available version, consider using ubuntu-24.04 instead of ubuntu-latest, or update the PR description to clarify that the goal is to use a floating version tag.
| os-version: "ubuntu-latest" | ||
| - shard_name: "xmodule-with-lms" | ||
| python-version: "3.11" | ||
| django-version: "pinned" | ||
| mongo-version: "7.0" | ||
| os-version: "ubuntu-22.04" | ||
| os-version: "ubuntu-latest" |
There was a problem hiding this comment.
The comments on lines 50-56 explain that the include section exists specifically to "run some subset of the tests on the older version of Ubuntu" to "find major issues quickly while we're in a situation where we support two versions." By changing both the main matrix os-version and these include entries to ubuntu-latest, the entire purpose of this dual-version testing strategy is defeated - all tests will now run on the same Ubuntu version. If the goal is to maintain testing across multiple Ubuntu versions, the include entries should remain on an older pinned version (e.g., ubuntu-22.04) while the main matrix could use ubuntu-24.04 or ubuntu-latest.
timmc-edx
left a comment
timmc-edx
left a comment
There was a problem hiding this comment.
I think we should skip this -- our fork shouldn't diverge from upstream except where we really need it to. Open edX maintainers will ensure the Ubuntu versions are updated.
|
I'm going to close this ticket for the reason @timmc-edx explained in #75 (review). That said, the reason this is blocked from happening in edx-platform master was related to legacy codejail (I believe). So I added a task to openedx#36639 for picking this up. |
Description
Updating the latest version of ubuntu
Ticket Reference
https://2u-internal.atlassian.net/browse/BOMS-285