fix: handle CourseOverview.DoesNotExist exception in optout creation #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds exception handling to prevent user retirement failures when CourseOverview records are missing for enrollments. The fix wraps the optout creation logic in a try-except block to catch and log CourseOverview.DoesNotExist exceptions, allowing the retirement process to continue by skipping problematic enrollments.
Key changes:
- Added exception handling in
force_optout_allsignal handler to gracefully handle missing CourseOverview records - Added CourseOverview import for exception handling
- Added warning log message when CourseOverview is not found
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
User retirement failed when CourseOverview records were missing, causing
CourseOverview.DoesNotExistexceptions in bulk email signal handler.Solution:
Added exception handling in
force_optout_allsignal handler:CourseOverviewimportOptout.objects.get_or_create()in try/except blockPrivate JIRA Link:
BOMS-370