Fix loading gerbv on Linux #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**Problem** On modern ubuntu, and probably many other Linux distributions, the `gerbv` DLL is *not* in `/usr/local/lib/`. For example, for me, it is at `/usr/lib/x86_64-linux-gnu/libgerbv.so.1`. This was hard-coded for some reason in 1288e13, but the real fix for the problem was in ea39c55, raising an exception when the library can't be identified. If it was identified, hardcoding the path is unlikely to help, and very likely to break things, as it does for me. This change makes the library load correctly on linux.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
On modern ubuntu, and probably many other Linux distributions, the
gerbvDLL is not in/usr/local/lib/. For example, for me, it is at/usr/lib/x86_64-linux-gnu/libgerbv.so.1. This was hard-coded for some reason in 1288e13, but the real fix for the problem was in ea39c55, raising an exception when the library can't be identified. If it was identified, hardcoding the path is unlikely to help, and very likely to break things, as it does for me.Solution
This change makes the library load correctly on linux by removing the check and just letting
find_libraryandCDLLdo their thing, as they were implemented to do.