-
-
Notifications
You must be signed in to change notification settings - Fork 68
feat: windows support #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
43c27ad to
c938c4a
Compare
| defp app_globs do | ||
| app_globs = Enum.map(@allowed_apps, fn app_name -> "/**/#{app_name}*/ebin" end) | ||
| ["/**/priv" | app_globs] | ||
| end | ||
|
|
||
| def glob_paths(_) do | ||
| entries = | ||
| for entry <- :code.get_path(), | ||
| entry_string = List.to_string(entry), | ||
| entry_string != ".", | ||
| Enum.any?(app_globs(), &PathGlob.match?(entry_string, &1, match_dot: true)) do | ||
| entry | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows was not finding the files on windows with the old code
0f11f1a to
9269f26
Compare
|
Is this ready for review? |
|
@mhanberg almost, there's a few failing tests on windows I'm fixing. I'll tag you when it is. |
86651c4 to
1e93243
Compare
|
@mhanberg it's ready for review now! |
|
mise support windows. https://mise.jdx.dev/installing-mise.html#windows-winget |
Sorry, got lost in the holiday jumble. The recent comment made me remember this. I'll try and review and get it running. |
|
Sorry, still haven't gotten a chance, i have to climb under my desk and plug my desktop into the monitor 😭. Will try and get to it soon. If someone else who runs windows wants to test this out, it would be a great boon! |
|
Hi I tried to invoke it in terminal - got error (I checked, file exists) I tried to pass it to zed by next construction, it was failing. I did not tried lexical, because, as I understand, it does not support windows - lexical-lsp/lexical#762 |
|
Is your username obfuscated there are did it actually print out the weird Unicode characters? |
|
@mhanberg It's |
This is the same method Livebook uses for the very same reasons
a6d85ff to
62d353c
Compare
|
Apparently windows 11 is a pita to get on a vm, still working on that. Might have to try windows 10 |
windows is slow :/
367c1f8 to
12d80bb
Compare
|
Attempting to boot with neovim, i get the following error
haven't investigated more yet. |
|
From a quick glance at that error, it seems like a Project was created without a |
Potentially, will need to dig in more later, was just able to get my VM up and running during my lunch hour. |
29bca63 to
68f178e
Compare
horrible "fix" but I can't reproduce this issue locally and I don't know if it's CI slowness or something else going on
|
@mhanberg are you seeing that only in this branch or does it happen in main too? |
|
I didn't try on main cuz I assumed it wouldn't work at all. |
|
Ah gotcha, no I haven't seen it before on main on Mac or Linux. |
mhanberg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since everything compiles and runs, I say we merge this and then fix any issues that come up.
We'll have to further investigate the issue brought up here, can create an ticket for that.






Adds support for Windows
Closes #89
Fixes #60
Also adds a
just start-tcptask to start a plain release in TCP mode for development because expert builds burrito releases SO SLOW on my windows machine that it spent more time waiting for the build than actually working on the relevant changesOne note here is that this implementation uses the user's globally installed elixir on Windows. I don't know if there's any version manager like mise/asdf/nix on windows, if there is we'll need to get the PATH for the project folder like we do for Unix
Another note is that for reasons I don't yet understand windows is way slower than unix even on my beefy machine, so I had to increase the timeouts for a few tests. I was also seeing a few timing issues due to this that I hope were reliably mitigated.