-
-
Notifications
You must be signed in to change notification settings - Fork 67
chore: improve plain releases for local builds #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fd183c2 to
e28c157
Compare
| #{cmd} --help | ||
| """) | ||
|
|
||
| # Silence the release "announce" message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't like the default announcement message because it's misleading, you can't run expert with them and you can't pass cli flags to start or start_iex, so figured this way to replace it with a custom one.
| To use it, point your editor LSP configuration to: | ||
| #{executable_path} --stdio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want all of these to show the full executable_path, for consistency.
apps/expert/rel/expert.bat
Outdated
| @@ -0,0 +1,5 @@ | |||
| @echo off | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we have this file and the one in overlays?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agh, there's a bug in the filetree plugin I use on neovim that would refuse to delete this file every time I moved it or renamed it. I forgot to remove this one again before committing
|
This would be a chore, not a feat I think maybe it should be Will require changing the CD workflows |
e28c157 to
af7cb91
Compare
Updates the
just release-plaincommand to include astart_expertscript that takes care of wrapping the expert executable and pass the CLI flags correctly.Also updates the docs nudging people to use plain releases when building expert from source.
The main idea here is that we make it easier and faster for users building expert from source (eg when developing) and reserve the cross platform burrito executables for the official releases that regular users download.