Skip to content

Fix: Fix new WikiTree Location Tag failure to parse #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GuyKh wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Fix new WikiTree Location Tag failure to parse #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 32 additions & 18 deletions collections/wikitree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,23 +337,37 @@ function parseWikiTree(htmlstring, familymembers, relation) {
return profiledata;
}

function parseWikiEvent(vitalstring) {
var data = [];
var vitalinfo = vitalstring.trim().replace("[location unknown]", "").replace("[date unknown]", "");
var datesplit = vitalinfo.split(" in ");
if (datesplit.length > 0) {
var dateval = datesplit[0].trim();
dateval = cleanDate(dateval);
if (dateval !== "") {
data.push({date: dateval});
}
if (datesplit.length > 1) {
var eventlocation = datesplit[1].trim();
if (eventlocation !== "") {
data.push({id: geoid, location: eventlocation});
geoid++;
}
}
function parseWikiEvent(eventString) {
Copy link
Collaborator Author

@GuyKh GuyKh Feb 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically - split into [... (at ... - optional) ... in ...]

// Return empty array if input is invalid
if (!eventString || typeof eventString !== 'string') {
return [];
}

const eventData = [];

// Clean and normalize the input string
const cleanedString = eventString
.trim()
.replace("[location unknown]", "")
.replace("[date unknown]", "");

// Split into date and location parts
const [datePart, ...locationParts] = cleanedString.split(/\s+in\s+/);

// Parse date if present
const cleanedDate = cleanDate(datePart.trim());
if (cleanedDate) {
// Split date into date and (" at age 100") parts
[cleanDatePart, ...otherCleanParts] = cleanedDate.split(/\s+at\s+/);
eventData.push({ date: cleanDatePart });
}
return data;

if (locationParts) {
eventData.push({
id: geoid++,
location: locationParts[0]
});
}

return eventData;
}