Skip to content

Conversation

@mtotschnig
Copy link
Contributor

Google Play's pre-launch report runs AccesibilityScanner on my app and detected missing content descriptions in the color dialogue:
grafik

This change allows the user of the library to provide an array of color names matching the provided array of colors. If no color names are provided, the RGB value of the color will be set as content description.

This follows the following recommendation for accessible software: https://handreichungen.bfit-bund.de/accessible-uie/farbwaehler.html

  • Extend SimpleColorDialog and ColorField to accept an array of color names.

Testing

Added the new field to the test App.

No visible change. Just Talkback can provide user with names for selected colors.


My contribution follows "inbound=outbound" licensing as defined by the GitHub Terms of Service.

@eltos
Copy link
Owner

eltos commented Apr 7, 2025

I wonder how useful color customisation is for someone who needs a screen reader 🤔

Anyhow, adding accessibility can't do any bad. I would have made the color name(s) an additional optional argument to the various methods because it's so closely related, but dedicated methods also get the job done.

I'll merge shortly, thanks! 👍

@eltos eltos merged commit 071afd2 into eltos:main Apr 8, 2025
3 checks passed
@mtotschnig
Copy link
Contributor Author

I wonder how useful color customization is for someone who needs a screen reader 🤔

As far as I can imagine, it might be useful. On the one hand, for a blind person, if the colors are exposed via the screen reader, they can still use it for organization, the same a sighted person would do. On the other hand, screen readers are used by visually impaired persons, who are not completely blind, so supporting the visual information with textual information, could be useful. But I am not an expert in A11y, and try to follow best practices as far as I am aware of them.

Anyhow, adding accessibility can't do any bad. I would have made the color name(s) an additional optional argument to the various methods because it's so closely related, but dedicated methods also get the job done.

I'll merge shortly, thanks! 👍

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants