-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add ALC_EXT_capture to present OpenAL extensions #25837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add this one an existing test maybe?
119224c to
b181970
Compare
|
Updated the existing test with this extension. |
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Can you run |
|
Do I just run |
1618c81 to
684c214
Compare
|
Looks like main is currently out-of-date WRT codesize .. I will update there and you can rebase. |
|
codesizes updated in #25983 |
684c214 to
61e0078
Compare
The extension is already implemented, however, alcIsExtensionPresent wasn't reporting it as present.
61e0078 to
3d29660
Compare
|
I assume this failure is related to some of the recent commits, not this 😆 |
|
Landing without waiting for tests to pass since codesize tests have passed and the wasm2js failure looks unrelated. |
The extension is already implemented, however, alcIsExtensionPresent wasn't reporting it as present.