Skip to content

Conversation

@inolen
Copy link
Collaborator

@inolen inolen commented Nov 20, 2025

The extension is already implemented, however, alcIsExtensionPresent wasn't reporting it as present.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this one an existing test maybe?

@inolen inolen force-pushed the alc_ext_capture branch 2 times, most recently from 119224c to b181970 Compare December 18, 2025 09:04
@inolen
Copy link
Collaborator Author

inolen commented Dec 18, 2025

Updated the existing test with this extension.

Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sbc100
Copy link
Collaborator

sbc100 commented Dec 18, 2025

Can you run test/runner codesize --rebase (with emsdk install tot first) to update the codesize expectations.

@inolen
Copy link
Collaborator Author

inolen commented Dec 18, 2025

Do I just run emsdk install tot or do i need to install and then switch to it somehow? Haven't used emsdk much, I just followed along with the README to use my git fork and then frantically throw commands at my terminal until it works each time I have to update.

@inolen inolen force-pushed the alc_ext_capture branch 3 times, most recently from 1618c81 to 684c214 Compare December 18, 2025 21:10
@sbc100
Copy link
Collaborator

sbc100 commented Dec 18, 2025

Looks like main is currently out-of-date WRT codesize .. I will update there and you can rebase.

@sbc100
Copy link
Collaborator

sbc100 commented Dec 18, 2025

codesizes updated in #25983

The extension is already implemented, however, alcIsExtensionPresent
wasn't reporting it as present.
@inolen
Copy link
Collaborator Author

inolen commented Dec 18, 2025

I assume this failure is related to some of the recent commits, not this 😆

@sbc100
Copy link
Collaborator

sbc100 commented Dec 18, 2025

Landing without waiting for tests to pass since codesize tests have passed and the wasm2js failure looks unrelated.

@sbc100 sbc100 merged commit 5f59cb6 into emscripten-core:main Dec 18, 2025
24 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants