Register as singleton for console #13
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В
LaravelInitialEventPropagationServiceProviderInitialEventHolderрегистрируется как scope, что хорошо для http запросов.Но для консоли, если мы не используем класс Job, а просто делаем свою джобу как
class SomeJob implements ShouldQueueэто плохо, т.к.(new SetInitialEventArtisanSecurityMiddleware())->handle();который мы добавляем в Kernel фактически бесполезен. Т.к. инсансInitialEventHolderсбрасывается при каждой джобе иInitialEventстановится пустымПредлагаю для консольных команд все таки регистрировать его как синглтон