Skip to content

Conversation

@junkmd
Copy link
Collaborator

@junkmd junkmd commented Dec 28, 2025

Corrected the usage of assertRaises in test_puredispatch.py. Previously, msg was mistakenly used as error message validation.

This has been updated to use assertRaisesRegex with a compiled regex pattern to ensure proper validation of the expected ValueError messages.

Corrected the usage of `assertRaises` in `test_puredispatch.py`.
Previously, `msg` was mistakenly used as error
message validation.
This has been updated to use `assertRaisesRegex`
with a compiled regex pattern to ensure proper
validation of the expected `ValueError` messages.
@junkmd junkmd added this to the 1.4.15 milestone Dec 28, 2025
@junkmd junkmd added the tests enhance or fix tests label Dec 28, 2025
@codecov
Copy link

codecov bot commented Dec 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.04%. Comparing base (7c01639) to head (3970b6b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #891   +/-   ##
=======================================
  Coverage   85.04%   85.04%           
=======================================
  Files         126      126           
  Lines       11726    11728    +2     
=======================================
+ Hits         9972     9974    +2     
  Misses       1754     1754           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@junkmd junkmd merged commit 86d39f5 into enthought:main Dec 28, 2025
52 checks passed
@junkmd junkmd deleted the fix_test_puredispatch_msg branch December 28, 2025 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests enhance or fix tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant