Skip to content

Conversation

@vishalm
Copy link

@vishalm vishalm commented Aug 24, 2024

  1. Added requirements files
  2. This is mac os based requirements files

@prabhuramachandran
Copy link
Member

Thank you for your PR. I am not sure we want to fix the dependencies like this. @larsoner do you have an opinion on this?

@larsoner
Copy link
Collaborator

I have seen this used sometimes (e.g., in pyvistaqt), then dependabot comes through and updates something as a new release is made. Every once in a while something breaks. But in general in my experience it tends to create more busy work than help with progress. So I'm -0.5.

If we do add this, then we'd want to add a CI run that actually used the requirements.txt, and probably add a bot automerge (with suitable merge CI requirements) to mark any dependabot PR as automerge to reduce the maintenance burden. In other words, let dependabot open its PR, and it will get auto-merged if CIs are happy...

@prabhuramachandran
Copy link
Member

@larsoner, thank you. Given how bad I have been at the releases so far, I think any more busy work is not a good idea. Let me first get the release done before we consider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants