yqiao/master #1248
Open
yqiao/master #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add timeout parameter.
when deleting first check if index exists and ignore if it doesn't.
Fixed KeywordQuery and TermQuery so that they work for substructure search. Note query must be constructed with is_substructure=True.
…ile is rxn from chemaxon it may need sanitized with automap().
# Conflicts: # .ci/version.txt # api/dotnet/src/Indigo.Net.csproj # api/http/requirements.txt # api/http/setup.py # api/indigo-version.cmake # api/java/pom.xml # api/python/indigo/__init__.py # api/python/setup.py # api/r/DESCRIPTION # api/wasm/indigo-ketcher/package.json # bingo/bingo-elastic/java/pom.xml # bingo/bingo-elastic/python/bingo_elastic/__init__.py # bingo/bingo-elastic/python/bingo_elastic/elastic.py # bingo/bingo-elastic/python/setup.py # utils/indigo-ml/setup.py # utils/indigo-service/backend/service/requirements.txt
Contributor
Author
|
For aromotize() call on registration and post-processing perhaps it can preserve backward compatibility should we have a toggle on the ElasticRepository and AsyncElasticEpiository class with a default value set to True (so it can be set to false manually for legacy connections)? |
khyurri
requested changes
Sep 26, 2023
Collaborator
khyurri
left a comment
khyurri
left a comment
There was a problem hiding this comment.
Apologies for long review and thank you for your PR. Great to have new Query (TermQuery), but we would clarify some questions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Aleksandr Savelev as requested.