Skip to content

Conversation

@oyvindeide
Copy link
Collaborator

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.54%. Comparing base (b894195) to head (8fe82d0).
⚠️ Report is 19 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12202      +/-   ##
==========================================
- Coverage   90.58%   90.54%   -0.04%     
==========================================
  Files         435      436       +1     
  Lines       29933    30007      +74     
==========================================
+ Hits        27114    27171      +57     
- Misses       2819     2836      +17     
Flag Coverage Δ
cli-tests 37.37% <27.27%> (+0.02%) ⬆️
gui-tests 68.55% <30.30%> (-0.13%) ⬇️
performance-and-unit-tests 73.94% <93.93%> (+<0.01%) ⬆️
test 38.07% <9.09%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

new_configs = {}
for param_config in parameters_json.values():
if param_config["type"] == "field":
param_config["grid_dimensions"] = param_config.pop("ertbox_params")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be param_config.pop("ertbox_params", None)?

Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had a small comment in the migration but otherwise good.

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 31, 2025

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing oyvindeide:rename_ertbox (8fe82d0) with main (8c03d9e)

Summary

✅ 22 untouched benchmarks

@oddvarlia
Copy link
Collaborator

A comment: I am not sure renaming ertbox to grid_dimensions is a good approach since this contains more than grid dimensions. The class ErtboxParameters contains not only grid dimensions, but equally important a definition of a local coordinate system used for calculating the transformation of observations positions into the local grid coordinate system.

@oddvarlia oddvarlia self-requested a review December 3, 2025 19:49
Copy link
Collaborator

@oddvarlia oddvarlia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we should rename this to grid_dimensions since the class ErtboxParameters not only contains grid dimensions (nx,ny,nz) but equally important a definition of the local coordinate system for the field parameters. grid_dimensions is not a very descriptive name of the class ErtboxParameters

@oddvarlia oddvarlia requested a review from xjules December 3, 2025 19:53
@oyvindeide oyvindeide force-pushed the rename_ertbox branch 3 times, most recently from b125179 to b497559 Compare January 8, 2026 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants