Skip to content

Conversation

@frode-aarstad
Copy link
Contributor

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@frode-aarstad frode-aarstad marked this pull request as draft November 19, 2025 08:46
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.85%. Comparing base (2391480) to head (ad79517).
⚠️ Report is 4 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (2391480) and HEAD (ad79517). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (2391480) HEAD (ad79517)
test 4 3
gui-tests 4 3
cli-tests 4 3
performance-and-unit-tests 4 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main   #12336       +/-   ##
===========================================
- Coverage   90.61%   76.85%   -13.77%     
===========================================
  Files         433      433               
  Lines       29044    29046        +2     
===========================================
- Hits        26319    22323     -3996     
- Misses       2725     6723     +3998     
Flag Coverage Δ
cli-tests 37.81% <ø> (-0.01%) ⬇️
gui-tests 69.14% <ø> (-0.03%) ⬇️
performance-and-unit-tests ?
test 38.62% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad force-pushed the slow-mac-test branch 2 times, most recently from c0b4a35 to 8670fca Compare November 19, 2025 09:05
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 19, 2025

CodSpeed Performance Report

Merging #12336 will not alter performance

Comparing frode-aarstad:slow-mac-test (f220da5) with main (e60b40e)

Summary

✅ 22 untouched

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants