Skip to content

Conversation

@SAKavli
Copy link
Contributor

@SAKavli SAKavli commented Dec 15, 2025

Issue
Resolves #12432

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@SAKavli SAKavli force-pushed the add-export-misfit-button branch from 8367b6f to 9b90a09 Compare December 15, 2025 11:23
@SAKavli SAKavli force-pushed the add-export-misfit-button branch from 9b90a09 to 4e74616 Compare December 28, 2025 11:37
Update label on button change

Set width of QLineEdit

Add stretch to all QhBoxLayouts

Disable save button given existing filename

Define default file extension

Remove redundant QVBoxLayout

Make Qt methods classes

To squash
@SAKavli SAKavli force-pushed the add-export-misfit-button branch from 4e74616 to 185e34d Compare December 28, 2025 11:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2025

Codecov Report

❌ Patch coverage is 87.38739% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.60%. Comparing base (dc78922) to head (185e34d).

Files with missing lines Patch % Lines
...ui/tools/manage_experiments/storage_info_widget.py 89.52% 11 Missing ⚠️
...ok_implementations/workflows/export_misfit_data.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12506      +/-   ##
==========================================
- Coverage   90.62%   90.60%   -0.03%     
==========================================
  Files         432      432              
  Lines       29738    29848     +110     
==========================================
+ Hits        26951    27043      +92     
- Misses       2787     2805      +18     
Flag Coverage Δ
cli-tests 37.43% <0.00%> (-0.16%) ⬇️
gui-tests 68.76% <84.68%> (+0.06%) ⬆️
performance-and-unit-tests 73.94% <23.42%> (-0.19%) ⬇️
test 38.18% <0.00%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 28, 2025

CodSpeed Performance Report

Merging #12506 will not alter performance

Comparing SAKavli:add-export-misfit-button (185e34d) with main (dc78922)

Summary

✅ 22 untouched

@SAKavli
Copy link
Contributor Author

SAKavli commented Jan 5, 2026

As a design for this kind of behavior have been added for Parameters, I will scrap this PR and start over reusing that code.
b2b0eac

@SAKavli SAKavli closed this Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace EXPORT_MISFIT_DATA workflow with button in the gui

2 participants