Fixup refcase removal migration #12529
Merged
+209
−59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12529 +/- ##
==========================================
+ Coverage 90.63% 90.67% +0.03%
==========================================
Files 432 434 +2
Lines 29730 29755 +25
==========================================
+ Hits 26947 26981 +34
+ Misses 2783 2774 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12529 will not alter performanceComparing Summary
|
yngve-sk
force-pushed
the
25.12.remove-summary-refcase-fixup
branch
from
71a0e04 to
08ada00
Compare
andreas-el
reviewed
Dec 19, 2025
andreas-el
reviewed
Dec 19, 2025
yngve-sk
force-pushed
the
25.12.remove-summary-refcase-fixup
branch
3 times, most recently
from
3bb099a to
bf2214b
Compare
andreas-el
reviewed
Jan 5, 2026
...ent_serialization/test_that_dumped_enif_matches_snapshot/heat_equationconfig.ert/config.json
Outdated
Show resolved
Hide resolved
andreas-el
reviewed
Jan 5, 2026
yngve-sk
force-pushed
the
25.12.remove-summary-refcase-fixup
branch
2 times, most recently
from
c1946fd to
4947cb6
Compare
Remedy bug in removal in to12.py. Added as separate migration, since the to12.py faulty migration is already in effect for older migrated storages.
yngve-sk
force-pushed
the
25.12.remove-summary-refcase-fixup
branch
from
4947cb6 to
803ea8d
Compare
andreas-el
approved these changes
Jan 5, 2026
Contributor
andreas-el
left a comment
andreas-el
left a comment
There was a problem hiding this comment.
I think this is ready to go in. 🎖️
yngve-sk
added
the
release-notes:breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should go in after #12528. Prerequisite for #11513