Skip to content

Rename ExtParamConfig to EverestControl #12554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
frode-aarstad merged 2 commits into from
Jan 5, 2026
Merged

Rename ExtParamConfig to EverestControl #12554

frode-aarstad merged 2 commits into from
Jan 5, 2026
+44 −42

Conversation

@frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Dec 29, 2025 •
edited
Loading

Issue
Resolves #12158

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@frode-aarstad frode-aarstad self-assigned this Dec 29, 2025
@frode-aarstad frode-aarstad added the release-notes:skip If there should be no mention of this in release notes label Dec 29, 2025
Copilot AI reviewed Dec 29, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR renames the ExtParamConfig class to EverestControl to better reflect that it is exclusively used by Everest and make its purpose more explicit. This is a straightforward refactoring to improve code clarity.

  • Class renamed from ExtParamConfig to EverestControl in the main definition
  • All import statements updated across the codebase
  • Type annotations and hints updated in all affected files

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/ert/config/everest_control.py Renamed class from ExtParamConfig to EverestControl and updated docstring
src/ert/config/init.py Updated imports and exports to use EverestControl instead of ExtParamConfig
src/ert/config/ensemble_config.py Updated import and type hint in EnsembleConfig
src/ert/storage/local_experiment.py Updated import and type adapter annotation
src/ert/run_models/initial_ensemble_run_model.py Updated import and type annotation
src/ert/run_models/everest_run_model.py Updated imports, type hints in ext_param_configs property and _create_optimizer method
src/ert/run_models/_create_run_path.py Updated import and isinstance check
src/everest/config/control_config.py Updated import and return type of to_ert_parameter_config() method
src/everest/config/utils.py Updated import and function parameter type hint
src/everest/optimizer/everest2ropt.py Updated import and function parameter type hints
src/everest/optimizer/opt_model_transforms.py Updated import and function parameter type hint
tests/ert/unit_tests/storage/test_local_storage.py Updated import and test instantiation

@frode-aarstad frode-aarstad force-pushed the rename-ext-param-config branch from 7cd95ad to ad67efd Compare December 29, 2025 07:47
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (dc78922) to head (3ae9c87).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #12554   +/-   ##
=======================================
  Coverage   90.62%   90.63%           
=======================================
  Files         432      432           
  Lines       29738    29730    -8     
=======================================
- Hits        26951    26945    -6     
+ Misses       2787     2785    -2
Flag Coverage Δ
cli-tests 37.60% <45.45%> (+0.01%) ⬆️
gui-tests 68.70% <45.45%> (+0.01%) ⬆️
performance-and-unit-tests 74.14% <64.70%> (+<0.01%) ⬆️
test 38.34% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frode-aarstad frode-aarstad force-pushed the rename-ext-param-config branch from ad67efd to d295f7e Compare December 29, 2025 08:05
@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #12554 will not alter performance

Comparing frode-aarstad:rename-ext-param-config (3ae9c87) with main (0860a49)

Summary

✅ 22 untouched

@xjules
Copy link
Contributor

xjules commented Dec 29, 2025

What about storage migration with the renaming? Not sure though if everest actually needs it.

@frode-aarstad
Copy link
Contributor Author

frode-aarstad commented Dec 30, 2025

What about storage migration with the renaming? Not sure though if everest actually needs it.

I think that is taken care of by the to12 migrations.

to12.py

yngve-sk
yngve-sk reviewed Jan 5, 2026
View reviewed changes
yngve-sk
yngve-sk reviewed Jan 5, 2026
View reviewed changes
xjules
xjules reviewed Jan 5, 2026
View reviewed changes
src/ert/run_models/everest_run_model.py
# There will and must always be one EverestControl config for an
# Everest optimization.
return cast(list[ExtParamConfig], ext_params)
return cast(list[EverestControl], controls)
Copy link
Contributor

@xjules xjules Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this cast required?

Copy link
Contributor Author

@frode-aarstad frode-aarstad Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

xjules
xjules reviewed Jan 5, 2026
View reviewed changes
tests/everest/test_controls.py


def test_that_controls_ordering_is_the_same_for_ropt_and_extparam():
def test_that_controls_ordering_is_the_same_for_ropt_and_everest_control():
Copy link
Contributor

@xjules xjules Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, not sure if this makes the test name more readable 😄

xjules
xjules approved these changes Jan 5, 2026
View reviewed changes
Copy link
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @frode-aarstad !
Don't forget to squash the commits.
🚀

@frode-aarstad frode-aarstad merged commit 9c95d5a into equinor:main Jan 5, 2026
35 checks passed
@frode-aarstad frode-aarstad deleted the rename-ext-param-config branch January 5, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yngve-sk yngve-sk yngve-sk left review comments

Copilot code review Copilot Copilot left review comments

@xjules xjules xjules approved these changes

Assignees

@frode-aarstad frode-aarstad

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename ExtParamConfig to EverestControl

4 participants

@frode-aarstad @codecov-commenter @xjules @yngve-sk