Skip to content

Conversation

@xjules
Copy link
Contributor

@xjules xjules commented Dec 29, 2025

Issue
Resolves #12556

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@xjules xjules self-assigned this Dec 29, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.56%. Comparing base (7d7a64e) to head (1175cef).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12557      +/-   ##
==========================================
- Coverage   90.58%   90.56%   -0.03%     
==========================================
  Files         435      435              
  Lines       29915    29914       -1     
==========================================
- Hits        27098    27091       -7     
- Misses       2817     2823       +6     
Flag Coverage Δ
cli-tests 37.32% <0.00%> (+<0.01%) ⬆️
gui-tests 68.65% <87.50%> (+0.02%) ⬆️
performance-and-unit-tests 73.91% <87.50%> (-0.03%) ⬇️
test 38.08% <12.50%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 29, 2025

CodSpeed Performance Report

Merging #12557 will not alter performance

Comparing xjules:fix_param_endpoint (1175cef) with main (7d7a64e)

Summary

✅ 22 untouched

Copy link
Contributor

@frode-aarstad frode-aarstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@frode-aarstad
Copy link
Contributor

frode-aarstad commented Dec 30, 2025

Assuming no one else is using this endpoint. Maybe we should make an issue to remove it ?

Its used in webviz-ert:
https://github.dev/equinor/webviz-ert/blob/14d27bd8700e6bc554e49c2bdd3c4ae70e1672a1/webviz_ert/data_loader/__init__.py#L113

But its only using the ensemble_ids from the returned data so the webviz ert tests dont fail

Added an issue related to this equinor/webviz-ert#503

Since all parameters are pydentic, we can directly dump elements into
json in the darkstorage endpoints without the list.
@xjules xjules force-pushed the fix_param_endpoint branch from e45d49c to 1175cef Compare January 5, 2026 12:57
@xjules
Copy link
Contributor Author

xjules commented Jan 5, 2026

Assuming no one else is using this endpoint. Maybe we should make an issue to remove it ?

Its used in webviz-ert: https://github.dev/equinor/webviz-ert/blob/14d27bd8700e6bc554e49c2bdd3c4ae70e1672a1/webviz_ert/data_loader/__init__.py#L113

But its only using the ensemble_ids from the returned data so the webviz ert tests dont fail

Added an issue related to this equinor/webviz-ert#503

I have another webviz-ert PR (equinor/webviz-ert#502), which will fix it.

@xjules xjules merged commit b8a7508 into equinor:main Jan 5, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update dark storage endpoint for parameters retrieval

3 participants