Skip to content

Conversation

@berland
Copy link
Contributor

@berland berland commented Dec 30, 2025

This translation service does not need to be part of the GUI code

Issue
Resolves #12462

Approach
Reapply offending commit after #12464 has been merged.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

This translation service does not need to be part of the GUI code
@berland berland self-assigned this Dec 30, 2025
@berland berland added the release-notes:maintenance Automatically categorise as maintenance change in release notes label Dec 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (7064211) to head (a52058f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12559      +/-   ##
==========================================
+ Coverage   90.61%   90.63%   +0.01%     
==========================================
  Files         432      432              
  Lines       29738    29730       -8     
==========================================
- Hits        26947    26945       -2     
+ Misses       2791     2785       -6     
Flag Coverage Δ
cli-tests 37.60% <33.33%> (+0.01%) ⬆️
gui-tests 68.70% <100.00%> (-0.02%) ⬇️
performance-and-unit-tests 74.14% <100.00%> (+0.01%) ⬆️
test 38.33% <33.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 30, 2025

CodSpeed Performance Report

Merging #12559 will not alter performance

Comparing berland:reapply (a52058f) with main (7064211)

Summary

✅ 22 untouched

Copy link
Contributor

@jonathan-eq jonathan-eq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine! 🚢

@berland berland merged commit 0860a49 into equinor:main Jan 2, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:maintenance Automatically categorise as maintenance change in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError: 'str' object has no attribute 'formatted_name' error in integration testing

3 participants