-
Notifications
You must be signed in to change notification settings - Fork 121
Fix openpbs integration test timing out #12560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12560 +/- ##
==========================================
- Coverage 90.62% 90.60% -0.03%
==========================================
Files 432 432
Lines 29738 29738
==========================================
- Hits 26951 26945 -6
- Misses 2787 2793 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #12560 will not alter performanceComparing Summary
|
berland
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
This commit fixes the issue where our mocked qdel bineries fails if the job has already finished (i.e - it was already killed by the TERMINATE_MSG over zmq), and would retry for 30 seconds. This was visible in "test_openpbs_driver_with_poly_example_failing_poll_fails_ert_and_propagates_exception_to_user"
404192b to
73e7487
Compare
|
I mocked some of the batching timeouts to be smaller (as we are only running two realizations anyways, this should be fine) |
|
Successfully created backport PR for |
This commit fixes the issue where our mocked qdel bineries fails if the job has already finished (i.e - it was already killed by the TERMINATE_MSG over zmq), and would retry for 30 seconds. This was visible in "test_openpbs_driver_with_poly_example_failing_poll_fails_ert_and_propagates_exception_to_user"
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable