Skip to content

Conversation

@jonathan-eq
Copy link
Contributor

This commit fixes the issue where our mocked qdel bineries fails if the job has already finished (i.e - it was already killed by the TERMINATE_MSG over zmq), and would retry for 30 seconds. This was visible in "test_openpbs_driver_with_poly_example_failing_poll_fails_ert_and_propagates_exception_to_user"

Issue
Resolves #my_issue

Approach
Short description of the approach

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@jonathan-eq jonathan-eq added this to SCOUT Jan 1, 2026
@jonathan-eq jonathan-eq moved this to In Progress in SCOUT Jan 1, 2026
@jonathan-eq jonathan-eq moved this from In Progress to Ready for Review in SCOUT Jan 1, 2026
@codecov-commenter
Copy link

codecov-commenter commented Jan 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.60%. Comparing base (dc78922) to head (73e7487).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12560      +/-   ##
==========================================
- Coverage   90.62%   90.60%   -0.03%     
==========================================
  Files         432      432              
  Lines       29738    29738              
==========================================
- Hits        26951    26945       -6     
- Misses       2787     2793       +6     
Flag Coverage Δ
cli-tests 37.59% <ø> (ø)
gui-tests 68.72% <ø> (+0.03%) ⬆️
performance-and-unit-tests 74.13% <ø> (ø)
test 38.32% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 1, 2026

CodSpeed Performance Report

Merging #12560 will not alter performance

Comparing jonathan-eq:fix-tests-timeout (73e7487) with main (7064211)

Summary

✅ 22 untouched

Copy link
Contributor

@berland berland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Jan 2, 2026
This commit fixes the issue where our mocked qdel bineries fails if the job has already finished (i.e - it was already killed by the TERMINATE_MSG over zmq), and would retry for 30 seconds. This was  visible in "test_openpbs_driver_with_poly_example_failing_poll_fails_ert_and_propagates_exception_to_user"
@jonathan-eq
Copy link
Contributor Author

I mocked some of the batching timeouts to be smaller (as we are only running two realizations anyways, this should be fine)
The test time changed 32s -> 2.5s. This probably started happening as a side effect of introducing batch killing jobs, but it is strange cod speed did not pick this up 🤔

@jonathan-eq jonathan-eq merged commit d553866 into equinor:main Jan 2, 2026
35 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Jan 2, 2026
@scout-team-app
Copy link

scout-team-app bot commented Jan 2, 2026

Successfully created backport PR for version-18.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants