Skip to content

Conversation

@larsevj
Copy link
Collaborator

@larsevj larsevj commented Nov 13, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.45%. Comparing base (06817f2) to head (f1ba11f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
+ Coverage   82.79%   83.45%   +0.66%     
==========================================
  Files          49       49              
  Lines        7281     7283       +2     
==========================================
+ Hits         6028     6078      +50     
+ Misses       1253     1205      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larsevj larsevj force-pushed the add_test_for_validation branch from 0ed2a0d to f1ba11f Compare November 13, 2025 13:24
@larsevj larsevj marked this pull request as ready for review November 14, 2025 08:46
@larsevj larsevj requested a review from Copilot November 14, 2025 08:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR significantly enhances test coverage for the create_date_files functionality by adding comprehensive parametrized tests and simplifying the validation logic.

  • Adds parametrized tests for CREATE_DATE_FILES parameter validation in ERT configuration
  • Refactors existing tests to use pytest parametrize for better coverage and maintainability
  • Simplifies the validation logic in CreateDateFiles forward model step by removing unnecessary class variables and streamlining error handling
  • Adds proper handling of empty string arguments by converting them to None

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tests/test_hook_implementations.py Adds comprehensive parametrized tests for CREATE_DATE_FILES validation, refactors imports with alias, and introduces DEFAULT_CONFIG template
tests/test_create_date_files.py Refactors multiple test functions into parametrized tests, adds extensive validation test cases, introduces fixture for sample YAML data, and adds multiple main() function test scenarios
src/subscript/hook_implementations/forward_model_steps.py Simplifies validation logic by removing ClassVar usage, adds default_mapping for optional parameters, and streamlines error message formatting
src/subscript/create_date_files/create_date_files.py Adds empty string to None conversion using or None pattern for proper argument handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@larsevj larsevj merged commit 5a769e6 into main Nov 14, 2025
11 checks passed
@larsevj larsevj deleted the add_test_for_validation branch November 14, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants