Rails 3.1 upgrade #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove devise boilerplate templates - update devise translations - fix some haml templates - add Array#rand which was removed in rails > 2.3.8
…rivate Array#rand
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking for an exception catcher for my private needs, I found ErrorNot in my list of projects to check. As a way to get a grasp of its internal I upgraded it to a more up-to-date stack (Rails 3.1.0, RSpec 2.6.0, MongoMapper 0.9.1,...).
I don't know what's your plan about ErrorNot, but here's a pull request with all those changes, all specs are green. I did only a little bit of manual testing and it looked like it's working.