-
Notifications
You must be signed in to change notification settings - Fork 60
feat: lock access to underlying cfitsio object #481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckermr
commented
Dec 9, 2025
beckermr
commented
Dec 9, 2025
beckermr
commented
Dec 9, 2025
esheldon
reviewed
Dec 10, 2025
fitsio/fitsio_pywrap.c
Outdated
| "Shared use of FITS object between threads detected! " | ||
| "`cfitsio` does NOT support shared use of FITS file " | ||
| "pointers! You can read from the same FITS file with " | ||
| "multiple threads, but each threads to open the file " |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"each thread must open"
Collaborator
Author
|
I'm not sure if I am going to want to merge this one. |
Collaborator
Author
|
I am going to close this pull request. I think locking should be the responsibility of the user since it is so use case dependent and likely needs to be done at the python level anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds locks to prevent concurrent usage of the cfitsio object.
See https://py-free-threading.github.io/porting/#raising-errors-under-shared-concurrent-use.
There are a lot of potential issues here, but the main ones are that
In other words, while I have ensured that no thread uses the same cfitsio file pointer at the same time, I have not ensured that a given thread can lock all of the python+C data structures long enough to do a fully consistent operation.
So for example, the lock is not held long enough for the thread to write image data via the C layer and also update the HDU list in the python layer.
So the locks as they are implemented now are formally correct, but don't really help the user avoid important race conditions.