Skip to content

feat(l2vpn): enhance release operation with audit logging and idempotency #617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Montana wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(l2vpn): enhance release operation with audit logging and idempotency #617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 42 additions & 5 deletions backend/src/main/java/net/es/oscars/resv/svc/L2VPNService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,13 @@
import net.es.oscars.web.simple.Validity;
import net.es.topo.common.devel.DevelUtils;
import org.apache.commons.lang3.tuple.Pair;
import org.springframework.security.core.Authentication;
import org.springframework.security.core.context.SecurityContextHolder;
import org.springframework.stereotype.Component;

import java.util.ArrayList;
import java.util.List;
import java.util.NoSuchElementException;


@Component
Expand Down Expand Up @@ -67,10 +70,46 @@ public BandwidthAvailabilityResponse bwAvailability(L2VPN l2VPN) throws ConnExce
return connSvc.bwAvailability(simpleConnection);
}


public void release(String name) throws ConnException, ConsistencyException {
Connection c = connSvc.findConnection(name).orElseThrow();
connSvc.release(c);
log.info("Attempting to release L2VPN connection: {}", name);

// find the connection - if not found, assume already released (idempotent behavior)
Connection c;
try {
c = connSvc.findConnection(name).orElseThrow();
} catch (NoSuchElementException e) {
log.info("L2VPN connection {} not found - assuming already released", name);
return; // idempotent operation
}

// get initiator information for audit trail
String initiator = "unknown";
try {
Authentication auth = SecurityContextHolder.getContext().getAuthentication();
if (auth != null && auth.getName() != null) {
initiator = auth.getName();
}
} catch (Exception e) {
log.warn("Unable to retrieve authentication context for release operation", e);
}

// log release initiation with full context
log.info("L2VPN_RELEASE_INITIATED - name: {}, connectionId: {}, phase: {}, state: {}, initiator: {}",
name,
c.getConnectionId(),
c.getPhase(),
c.getState(),
initiator);

// perform the actual release
try {
connSvc.release(c);
log.info("L2VPN_RELEASE_COMPLETED - name: {}, connectionId: {}", name, c.getConnectionId());
} catch (Exception e) {
log.error("L2VPN_RELEASE_FAILED - name: {}, connectionId: {}, error: {}",
name, c.getConnectionId(), e.getMessage(), e);
throw e;
}
}

public L2VPN createOrReplace(L2VPN l2VPN) throws ConnException, ConsistencyException {
Expand Down Expand Up @@ -113,6 +152,4 @@ public ValidationResponse validate(L2VPN l2VPN, ConnectionMode mode) {
public void clear() {
connSvc.getConnRepo().deleteAll();
}


}