Skip to content

Conversation

@vortigont
Copy link
Contributor

ArduinoOTA and HTTPUpdate uses hardcoded Update instance to execute update writes which is not created if NO_GLOBAL_UPDATE or NO_GLOBAL_INSTANCES flag is defined.

refactor ArduinoOTA/HTTPUpdate clases to use an UpdateClass instance pointer member, it fixes build error and also allows to use UpdateClass derivatives as update executors.

@vortigont vortigont requested review from a team and me-no-dev as code owners December 9, 2025 05:48
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "fix(OTA): ArduinoOTA, HTTPUpdate build fails with NO_GLOBAL_UPDATE flag":
    • scope/component should be lowercase without whitespace, allowed special characters are _ / . , * - .

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "Update_noglobfix" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello vortigont, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against d45c618

`ArduinoOTA` and `HTTPUpdate` uses hardcoded `Update` instance to execude update writes
which is not created if `NO_GLOBAL_UPDATE` or `NO_GLOBAL_INSTANCES` flag is defined

refactor ArduinoOTA/HTTPUpdate clases to use an UpdateClass instance pointer member,
it fixes build error and also allows to use UpdateClass derivatives as update executors.
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C5💚 -2980💚 -0.030.000⚠️ +160.00⚠️ +0.03
ESP32P40⚠️ +3780.00⚠️ +0.040⚠️ +160.00⚠️ +0.04
ESP32S3💚 -356⚠️ +4💚 -0.040.00000.000.00
ESP32S2💚 -400⚠️ +4💚 -0.040.00000.000.00
ESP32C3💚 -2980💚 -0.030.000⚠️ +160.00⚠️ +0.04
ESP32C6💚 -2980💚 -0.030.00000.000.00
ESP32💚 -364⚠️ +16💚 -0.040.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C5ESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/ArduinoOTA/examples/BasicOTA💚 -120⚠️ +37800000💚 -120💚 -120⚠️ +160
libraries/HTTPUpdate/examples/httpUpdate💚 -2820⚠️ +1080💚 -3560💚 -4000💚 -2820💚 -2820💚 -3480
libraries/HTTPUpdate/examples/httpUpdateSPIFFS💚 -2980⚠️ +920💚 -3520💚 -3520💚 -2980💚 -2980💚 -3360
libraries/HTTPUpdate/examples/httpUpdateSecure💚 -2980⚠️ +1000💚 -3560💚 -3560💚 -2980💚 -2980💚 -3640
libraries/WebServer/examples/HttpAdvancedAuth💚 -120⚠️ +370⚠️ +160000💚 -120💚 -120⚠️ +160
libraries/WebServer/examples/HttpAuthCallback💚 -120⚠️ +370⚠️ +16⚠️ +40⚠️ +40💚 -120💚 -120⚠️ +160
libraries/WebServer/examples/HttpAuthCallbackInline💚 -120⚠️ +370⚠️ +16⚠️ +40⚠️ +40💚 -120💚 -120⚠️ +160
libraries/WebServer/examples/HttpBasicAuth💚 -120⚠️ +378⚠️ +160000💚 -120💚 -120⚠️ +160
libraries/WebServer/examples/HttpBasicAuthSHA1💚 -120⚠️ +378⚠️ +160000💚 -120💚 -120⚠️ +160
libraries/WebServer/examples/HttpBasicAuthSHA1orBearerToken💚 -12⚠️ +16⚠️ +37000000💚 -12⚠️ +16💚 -120⚠️ +160

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Results

 83 files   83 suites   27m 45s ⏱️
 55 tests  55 ✅ 0 💤 0 ❌
598 runs  598 ✅ 0 💤 0 ❌

Results for commit d45c618.

♻️ This comment has been updated with latest results.

@lucasssvaz lucasssvaz added the Status: Pending Merge Pull Request is ready to be merged label Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Pending Merge Pull Request is ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants