Skip to content

Conversation

@cnadler86
Copy link
Contributor

@cnadler86 cnadler86 commented Nov 7, 2025

Description

This PR add proper handle of sensor.set_pixformat return values in order to throw an error, if the function didn't return a non-error value. To do so, a new ESP_ERR_CAMERA_FAILED_TO_SET_PIXEL_FORMAT was added.

Related

None

Testing

I tested it with omnivision sensors with a ESP32S3 with IDF 5.4.2


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@cnadler86
Copy link
Contributor Author

@me-no-dev it looks like something changed in the last idf for the esp32 target. The build errors are not related work the PR.

I synced with the master branch and IMHO I think this PR could get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants