Skip to content

Fix for issue #470 #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cloetensbrecht wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Fix for issue #470 #474

cloetensbrecht wants to merge 1 commit into from

Conversation

@cloetensbrecht
Copy link

@cloetensbrecht cloetensbrecht commented Apr 10, 2024

Fixes #470 .

Changes proposed in this pull request:

  • Replace $type::class by get_class($type)

maxfenton
maxfenton reviewed Apr 12, 2024
View reviewed changes
Copy link

@maxfenton maxfenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@anchovy anchovy mentioned this pull request Jun 4, 2024
Open
@baronvertigovongrahamthesecondofsealand
Copy link

baronvertigovongrahamthesecondofsealand commented Apr 28, 2025

Could we get this merged in please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxfenton maxfenton maxfenton left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cloetensbrecht @baronvertigovongrahamthesecondofsealand @maxfenton