Python 3.13 🚂 #7096
Merged
Python 3.13 🚂 #7096
+1,191
−618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnewart
added
the
do not merge
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
16 tasks
johnewart
force-pushed
the
johnewart/python3.13
branch
from
8ef216f to
39d0b5e
Compare
erosselli
reviewed
Jan 6, 2026
docs/fides/Dockerfile
Outdated
| @@ -1,10 +1,11 @@ | |||
| FROM python:3.10.16-slim-bookworm AS build | |||
| FROM python:3.12-slim-bookworm AS build | |||
Contributor
There was a problem hiding this comment.
shouldn't this be using python 3.13?
Collaborator
Author
There was a problem hiding this comment.
It's for generating the docs but yes, it should probably just be the same 😄
Comment on lines
38
to
48
| from enum import StrEnum | ||
|
|
||
| class ManualTaskExecutionTiming(StrEnum): | ||
| """Enum for when a manual task should be executed in the privacy request DAG.""" | ||
|
|
||
| pre_execution = "pre_execution" # Execute before the main DAG | ||
| post_execution = "post_execution" # Execute after the main DAG | ||
| parallel = "parallel" # Execute in parallel with the main DAG | ||
|
|
||
|
|
||
| class ManualTaskType(str, Enum): | ||
| from enum import StrEnum |
Comment on lines
+560
to
+562
| If an identity field with the same field_name already exists for this privacy request, | ||
| it will be replaced with the new value to prevent duplicate records. |
Contributor
There was a problem hiding this comment.
why is this change needed ? 🤔
|
|
||
|
|
||
| class ConsentMechanism(str, Enum): | ||
| from enum import StrEnum |
Contributor
There was a problem hiding this comment.
can we put the imports top-level ?
| ConnectionNotFoundException, | ||
| KeyOrNameAlreadyExists, | ||
| SaaSConfigNotFoundException, | ||
| ValidationError, |
Comment on lines
206
to
207
| @pytest.mark.skip("Fails in 3.13 and can probably be removed anyway.") | ||
| def test_abstract_class_attributes(self): |
Contributor
There was a problem hiding this comment.
tagging @JadeCara since I think she knows this code best
Contributor
There was a problem hiding this comment.
Yeah this one can be removed :)
Comment on lines
+415
to
+417
| @pytest.mark.skip( | ||
| "This test just verifies that the S3 client can download large files" | ||
| ) |
Contributor
There was a problem hiding this comment.
why are we skipping it though?
noxfile.py
Outdated
|
|
||
| REQUIRED_DOCKER_VERSION = "20.10.17" | ||
| REQUIRED_PYTHON_VERSIONS = ["3.9", "3.10"] | ||
| REQUIRED_PYTHON_VERSIONS = ["3.9", "3.10", "3.12", "3.13"] |
Contributor
There was a problem hiding this comment.
I think we should just leave 3.13 here no? or at least definitely remove 3.9 and 3.10
JadeCara
reviewed
Jan 6, 2026
…pollute the 3.13 functional changes with style / linter changes
johnewart
removed
the
do not merge
fides
|
||||||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 01m 35s |
| Commit |
|
| Committer | John Ewart |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
cypress/e2e/smoke_test.cy.ts • 1 failed test
| Test | Artifacts | |
|---|---|---|
| Smoke test > can submit an access request from the Privacy Center |
Screenshots
Video
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge this yet! 😆
(This PR is being opened to run all the tests)
Ticket ENG-36
Description Of Changes
Update to modern Python 🥳 🍰 🎉 🙌
Code Changes
Misc. fixes for compatibility
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works