-
Notifications
You must be signed in to change notification settings - Fork 84
Eng 2185 remove unused cols #7172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
JadeCara
wants to merge
15
commits into
ENG-2185-add-new-jsob-tree-col
Choose a base branch
from
ENG-2185-remove-unused-cols
base: ENG-2185-add-new-jsob-tree-col
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Eng 2185 remove unused cols #7172
JadeCara
wants to merge
15
commits into
ENG-2185-add-new-jsob-tree-col
from
ENG-2185-remove-unused-cols
+698
−3,313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ENG-2185-add-new-jsob-tree-col #7172 +/- ##
==================================================================
- Coverage 87.24% 85.04% -2.20%
==================================================================
Files 535 535
Lines 35324 35264 -60
Branches 4117 4107 -10
==================================================================
- Hits 30817 29992 -825
- Misses 3615 4348 +733
- Partials 892 924 +32 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket ENG-2185
Description Of Changes
🎯 Create manual tasks on the Consent Graph.
There are going to be a few PRs cleaning up some un-used functionality or adjusting functionality for improved usage patterns. This PR removes the columns which are now un-used and have been replaced by the JSONB storage tree. It is a clean up based on the first few rounds of customer use and learning actual usage patterns.
Past PRs:
This PR:
Future PRs:
Code Changes
.fides/db_dataset.yml- removed un used columnssrc/fides/api/alembic/migrations/versions/remove the unused columns.src/fides/api/models/conditional_dependency/conditional_dependency_base.pysrc/fides/api/models/digest/conditional_dependencies.pysrc/fides/api/models/manual_task/conditional_dependency.pySteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works