Skip to content

Conversation

@gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Dec 30, 2025

Description Of Changes

Reverse the import prefixes for Chakra UI and Ant Design components in the FidesUI design system to better signal the migration path:

  • Chakra components: Now exported with Chakra prefix (e.g., ChakraBox, ChakraFlex) and marked as @deprecated
  • Ant Design components: Now exported without the Ant prefix (e.g., Button, Table, Modal)

This makes it clear that Chakra is legacy/deprecated while Ant Design is the current standard.

Code Changes

  • Updated fidesui/src/index.ts to export Chakra components with Chakra prefix and added JSDoc @deprecated notices
  • Updated fidesui/src/index.ts to export Ant Design components without the Ant prefix
  • Updated all imports across admin-ui and privacy-center to use the new patterns
  • Updated frontend.mdc rules to reflect the new import conventions
  • Removed unused Breadcrumbs.tsx component (was no longer in use)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 30, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Dec 30, 2025 11:16pm
fides-privacy-center Ignored Ignored Dec 30, 2025 11:16pm

@gilluminate gilluminate marked this pull request as ready for review December 30, 2025 23:51
@gilluminate gilluminate requested a review from a team as a code owner December 30, 2025 23:51
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 30, 2025

Skipped: This PR changes more files than the configured file change limit: (704 files found, 100 file limit)

Copy link
Contributor

@speaker-ender speaker-ender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gilluminate gilluminate added this pull request to the merge queue Jan 5, 2026
Merged via the queue into main with commit 26f7d37 Jan 5, 2026
46 of 47 checks passed
@gilluminate gilluminate deleted the gill/chakra-ant-reversal branch January 5, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants