Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

fix favicon #610

Merged
Manav-Aggarwal merged 1 commit into from
Jul 31, 2025
Merged

fix favicon #610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .vitepress/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@ export default withMermaid({
head: [
["link", { rel: "icon", href: "/img/favicon.svg", type: "image/svg+xml" }],
["link", { rel: "icon", href: "/img/favicon.png", type: "image/png" }],
[
"link",
{ rel: "shortcut icon", href: "/favicon.ico", type: "image/x-icon" },
],
["meta", { name: "msapplication-TileColor", content: "#fff" }],
["meta", { name: "theme-color", content: "#fff" }],
[
Expand Down Expand Up @@ -56,7 +52,7 @@ export default withMermaid({
{
src: "https://plausible.celestia.org/js/plausible.js",
"data-domain": "ev.xyz",
defer: true,
defer: "",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using defer: "" is valid, but the idiomatic way to handle boolean attributes in VitePress is to use a boolean true. Setting an attribute to true will cause it to be rendered as a boolean attribute without a value (e.g., just defer), which is cleaner and the recommended approach.

Suggested change
defer: "",
defer: true,

Copy link
Member Author

@Manav-Aggarwal Manav-Aggarwal Jul 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint fails when I do this

},
],
],
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ Here you'll find comprehensive guides, and reference materials to help you make
To get started, clone the repository and run the following:

```bash
yarn run docs:dev
yarn run dev
```

This documentation site is built with [VitePress](https://vitepress.dev)
Expand Down
Binary file removed public/img/favicon-dark.ico
View file
Open in desktop
Binary file not shown.
Binary file modified public/img/favicon.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
176 changes: 164 additions & 12 deletions public/img/favicon.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading